Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1908253006: Revert of Generate Android .isolate files used for test()s (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org, bengr, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate Android .isolate files used for test()s (patchset #3 id:200001 of https://codereview.chromium.org/1914573002/ ) Reason for revert: Broke ui_base_unittests https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20GN/builds/33923/steps/ui_base_unittests/logs/stdio Original issue's description: > Reland of Generate Android .isolate files used for test()s > > Now uses gen.runtime rather than gen to be included by > builder/tester configurations. > > TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,agrieve@chromium.org > NOTRY=true > BUG=589318 TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,apacible@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589318 Committed: https://crrev.com/eb5809b120c5ffd941d8f43fa651588fc2af551a Cr-Commit-Position: refs/heads/master@{#389167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -242 lines) Patch
M android_webview/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/pylib/utils/isolator.py View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
D testing/generate_isolate.py View 1 chunk +0 lines, -114 lines 0 comments Download
M testing/test.gni View 6 chunks +5 lines, -105 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agrieve
Created Revert of Generate Android .isolate files used for test()s
4 years, 8 months ago (2016-04-22 18:14:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908253006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908253006/1
4 years, 8 months ago (2016-04-22 18:15:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 18:15:45 UTC) #4
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1916503002/ by agrieve@chromium.org. ...
4 years, 8 months ago (2016-04-22 18:36:12 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:49:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb5809b120c5ffd941d8f43fa651588fc2af551a
Cr-Commit-Position: refs/heads/master@{#389167}

Powered by Google App Engine
This is Rietveld 408576698