Issue 1908173002: [Custom Tabs]Unbreak buttons on bottom bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1908173002: [Custom Tabs]Unbreak buttons on bottom bar (Closed)

Created:
4 years, 8 months ago by Ian Wen

Modified:
4 years, 8 months ago

Reviewers:
Yusuf

CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Custom Tabs]Unbreak buttons on bottom bar After thre refactoring related to remoteviews based bottom bar, the old API stopped working. This CL fixes the breakage. BUG=604849 Review URL: https://codereview.chromium.org/1895813004 Cr-Commit-Position: refs/heads/master@{#388559} TBR=yusufo@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -8 lines)			Patch
M	chrome/android/java/res/values/ids.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java	View	1 chunk	+9 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Ian Wen

4 years, 8 months ago (2016-04-21 21:44:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48 (presubmit successful).