Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1895813004: [Custom Tabs]Unbreak buttons on bottom bar (Closed)

Created:
4 years, 8 months ago by Ian Wen
Modified:
4 years, 8 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Custom Tabs]Unbreak buttons on bottom bar After thre refactoring related to remoteviews based bottom bar, the old API stopped working. This CL fixes the breakage. BUG=604849 Committed: https://crrev.com/e60cd0c367c85708ce720719443ae0e58c08b59d Cr-Commit-Position: refs/heads/master@{#388559}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M chrome/android/java/res/values/ids.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java View 1 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ian Wen
PTAL
4 years, 8 months ago (2016-04-19 21:29:37 UTC) #2
Yusuf
https://codereview.chromium.org/1895813004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java (right): https://codereview.chromium.org/1895813004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java:74: LinearLayout layout = new LinearLayout(mActivity); Since we had tests ...
4 years, 8 months ago (2016-04-20 05:38:46 UTC) #3
Ian Wen
On 2016/04/20 05:38:46, Yusuf wrote: > https://codereview.chromium.org/1895813004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java > File > chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java > (right): > > ...
4 years, 8 months ago (2016-04-20 18:10:56 UTC) #4
Yusuf
lgtm
4 years, 8 months ago (2016-04-20 18:21:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895813004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895813004/20001
4 years, 8 months ago (2016-04-20 18:26:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 20:05:49 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:49 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e60cd0c367c85708ce720719443ae0e58c08b59d
Cr-Commit-Position: refs/heads/master@{#388559}

Powered by Google App Engine
This is Rietveld 408576698