Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Fix a few spurious string allocations in QuicCryptoServerStream and QuicCryptoStream. No functional change. Not flag protected.

Merge internal change: 119967190
https://codereview.chromium.org/1906803004/

Quic will push urls in x-associate-content and link headers upon ResponseHeadersComplete(). Change AcceptQuicClient() to start the request pipeline from PICKING_SERVICE for server push stream. Protected by FLAGS_quic_server_push.

Implemented server push feature in QUIC. This feature will be enabled by
both flag and connection option "kSPSH".

Merge internal change: 119871679
https://codereview.chromium.org/1905073002/

Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change, not protected.

This is in preparation for gRPC-over-QUIC to use a separate
QuicAlarmFactory for each GrpcQuicConnection. Currently there exists a
single Helper (and after this CL a single AlarmFactory) per Dispatcher,
and this is used to create alarms for all Connections.

gRPC-over-QUIC needs to add per-connection locking to connection alarms
before firing them, and a followup CL will create a different
AlarmFactory for each gRPC-over-QUIC connection, each with its own
mutex (rather than sharing one mutex across the alarms of connections
which is obviously terrible).

Merge internal change: 119778209
https://codereview.chromium.org/1905843003/

Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear. No behavior change.

(also removes very out of date QuicDispatcher constructor comment)

Merge internal change: 119753783
https://codereview.chromium.org/1907773002/

Deprecate FLAGS_quic_sslr_byte_conservation.

Merge internal change: 119678304
https://codereview.chromium.org/1906703002/

Deprecate FLAGS_quic_consolidate_onstreamframe_errors

Merge internal change: 119653892
https://codereview.chromium.org/1906473004/

Add a server push disabled test.

Merge internal change: 119645068
https://codereview.chromium.org/1911653003/

Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is now just an alias for unique_ptr, so this is a purely textual change. base/scoped_ptr.h will be removed soon.

Merge internal change: 119583512
https://codereview.chromium.org/1909453005/

Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is now just an alias for unique_ptr, so this is a purely textual change. base/scoped_ptr.h will be removed soon.

Merge internal change: 119581790
https://codereview.chromium.org/1911653002/

Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is now just an alias for unique_ptr, so this is a purely textual change. base/scoped_ptr.h will be removed soon.

Merge internal change: 119576588
https://codereview.chromium.org/1908723002/

Plumbs new SpdyFramerVisitorInterface method handling through QUIC test utilities, including the test client and test server. Preparation for CL 103292114.

Merge internal change: 119568788
https://codereview.chromium.org/1910593004/

Fixes QuicSpdyStream::ConsumeHeaderList to prod the sequencer when headers are consumed. Not yet used in production.

Merge internal change: 119562680
https://codereview.chromium.org/1910483004/

Stop returning unused return value from QuicPacketCreator::CopyToBuffer. No functional change. Not flag protected.

Merge internal change: 119557380
https://codereview.chromium.org/1897153007/

ignore invalid error code in QuicFramer when process GoAway, ConnectionClose, RstStream frames to do normal goaway, connection close, and stream reset. Flag protected by FLAGS_quic_ignore_invalid_error_code.

Merge internal change: 119551887
https://codereview.chromium.org/1904833002/

Adds a DebugString() method to QuicHeaderList.

Merge internal change: 119529330
https://codereview.chromium.org/1907683002/

Committed: https://crrev.com/16c74d1d99fc40179bd660f8cbbcab93ec7b4d8d
Cr-Commit-Position: refs/heads/master@{#389035}

[Ryan Hamilton, 2016-04-21 19:43:32]

Description was changed from

==========
Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Fix a few spurious string allocations in QuicCryptoServerStream and
QuicCryptoStream. No functional change. Not flag protected.

Merge internal change: 119967190


Quic will push urls in x-associate-content and link headers upon
ResponseHeadersComplete(). Change AcceptQuicClient() to start the request
pipeline from PICKING_SERVICE for server push stream. Protected by
FLAGS_quic_server_push.

Implemented server push feature in QUIC. This feature will be enabled by
both flag and connection option "kSPSH".

Merge internal change: 119871679


Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.
No behavior change, not protected.

This is in preparation for gRPC-over-QUIC to use a separate
QuicAlarmFactory for each GrpcQuicConnection. Currently there exists a
single Helper (and after this CL a single AlarmFactory) per Dispatcher,
and this is used to create alarms for all Connections.

gRPC-over-QUIC needs to add per-connection locking to connection alarms
before firing them, and a followup CL will create a different
AlarmFactory for each gRPC-over-QUIC connection, each with its own
mutex (rather than sharing one mutex across the alarms of connections
which is obviously terrible).

Merge internal change: 119778209


Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear.
No behavior change.

(also removes very out of date QuicDispatcher constructor comment)

Merge internal change: 119753783


Deprecate FLAGS_quic_sslr_byte_conservation.

Merge internal change: 119678304


Deprecate FLAGS_quic_consolidate_onstreamframe_errors

Merge internal change: 119653892


Add a server push disabled test.

Merge internal change: 119645068


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119583512


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119581790


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119576588


Plumbs new SpdyFramerVisitorInterface method handling through QUIC test
utilities, including the test client and test server. Preparation for CL
103292114.

Merge internal change: 119568788


Fixes QuicSpdyStream::ConsumeHeaderList to prod the sequencer when headers are
consumed. Not yet used in production.

Merge internal change: 119562680


Stop returning unused return value from QuicPacketCreator::CopyToBuffer. No
functional change. Not flag protected.

Merge internal change: 119557380


ignore invalid error code in QuicFramer when process GoAway, ConnectionClose,
RstStream frames to do normal goaway, connection close, and stream reset. Flag
protected by FLAGS_quic_ignore_invalid_error_code.

Merge internal change: 119551887


Adds a DebugString() method to QuicHeaderList.

Merge internal change: 119529330
==========

to

==========
Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Fix a few spurious string allocations in QuicCryptoServerStream and
QuicCryptoStream. No functional change. Not flag protected.

Merge internal change: 119967190
https://codereview.chromium.org/1906803004/


Quic will push urls in x-associate-content and link headers upon
ResponseHeadersComplete(). Change AcceptQuicClient() to start the request
pipeline from PICKING_SERVICE for server push stream. Protected by
FLAGS_quic_server_push.

Implemented server push feature in QUIC. This feature will be enabled by
both flag and connection option "kSPSH".

Merge internal change: 119871679
https://codereview.chromium.org/1905073002/


Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.
No behavior change, not protected.

This is in preparation for gRPC-over-QUIC to use a separate
QuicAlarmFactory for each GrpcQuicConnection. Currently there exists a
single Helper (and after this CL a single AlarmFactory) per Dispatcher,
and this is used to create alarms for all Connections.

gRPC-over-QUIC needs to add per-connection locking to connection alarms
before firing them, and a followup CL will create a different
AlarmFactory for each gRPC-over-QUIC connection, each with its own
mutex (rather than sharing one mutex across the alarms of connections
which is obviously terrible).

Merge internal change: 119778209
https://codereview.chromium.org/1905843003/


Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear.
No behavior change.

(also removes very out of date QuicDispatcher constructor comment)

Merge internal change: 119753783
https://codereview.chromium.org/1907773002/


Deprecate FLAGS_quic_sslr_byte_conservation.

Merge internal change: 119678304
https://codereview.chromium.org/1906703002/


Deprecate FLAGS_quic_consolidate_onstreamframe_errors

Merge internal change: 119653892
https://codereview.chromium.org/1906473004/


Add a server push disabled test.

Merge internal change: 119645068
https://codereview.chromium.org/1911653003/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119583512
https://codereview.chromium.org/1909453005/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119581790
https://codereview.chromium.org/1911653002/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119576588
https://codereview.chromium.org/1908723002/


Plumbs new SpdyFramerVisitorInterface method handling through QUIC test
utilities, including the test client and test server. Preparation for CL
103292114.

Merge internal change: 119568788
https://codereview.chromium.org/1910593004/


Fixes QuicSpdyStream::ConsumeHeaderList to prod the sequencer when headers are
consumed. Not yet used in production.

Merge internal change: 119562680
https://codereview.chromium.org/1910483004/


Stop returning unused return value from QuicPacketCreator::CopyToBuffer. No
functional change. Not flag protected.

Merge internal change: 119557380
https://codereview.chromium.org/1897153007/


ignore invalid error code in QuicFramer when process GoAway, ConnectionClose,
RstStream frames to do normal goaway, connection close, and stream reset. Flag
protected by FLAGS_quic_ignore_invalid_error_code.

Merge internal change: 119551887
https://codereview.chromium.org/1904833002/


Adds a DebugString() method to QuicHeaderList.

Merge internal change: 119529330
https://codereview.chromium.org/1907683002/
==========

[Ryan Hamilton, 2016-04-21 19:43:55]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[Ryan Hamilton, 2016-04-21 19:43:56]

Note: this CL's patch set 2 has git cl format changes.

[ramant (doing other things), 2016-04-21 21:40:06]

lgtm

[Ryan Hamilton, 2016-04-21 22:04:25]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-04-21 22:04:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1908103002/#ps40001
(title: "Fix comments")

[commit-bot: I haz the power, 2016-04-21 22:04:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908103002/40001

[Ryan Hamilton, 2016-04-21 22:23:43]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-04-21 22:23:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1908103002/#ps60001
(title: "net export")

[commit-bot: I haz the power, 2016-04-21 22:24:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908103002/60001

[commit-bot: I haz the power, 2016-04-22 00:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:04:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ryan Hamilton, 2016-04-22 01:27:16]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-04-22 01:27:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908103002/60001

[commit-bot: I haz the power, 2016-04-22 02:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 02:39:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ryan Hamilton, 2016-04-22 04:51:47]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-04-22 04:52:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908103002/60001

[Ryan Hamilton, 2016-04-22 04:55:19]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-04-22 04:55:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1908103002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-04-22 04:55:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908103002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908103002/80001

[commit-bot: I haz the power, 2016-04-22 06:14:20]

Description was changed from

==========
Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Fix a few spurious string allocations in QuicCryptoServerStream and
QuicCryptoStream. No functional change. Not flag protected.

Merge internal change: 119967190
https://codereview.chromium.org/1906803004/


Quic will push urls in x-associate-content and link headers upon
ResponseHeadersComplete(). Change AcceptQuicClient() to start the request
pipeline from PICKING_SERVICE for server push stream. Protected by
FLAGS_quic_server_push.

Implemented server push feature in QUIC. This feature will be enabled by
both flag and connection option "kSPSH".

Merge internal change: 119871679
https://codereview.chromium.org/1905073002/


Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.
No behavior change, not protected.

This is in preparation for gRPC-over-QUIC to use a separate
QuicAlarmFactory for each GrpcQuicConnection. Currently there exists a
single Helper (and after this CL a single AlarmFactory) per Dispatcher,
and this is used to create alarms for all Connections.

gRPC-over-QUIC needs to add per-connection locking to connection alarms
before firing them, and a followup CL will create a different
AlarmFactory for each gRPC-over-QUIC connection, each with its own
mutex (rather than sharing one mutex across the alarms of connections
which is obviously terrible).

Merge internal change: 119778209
https://codereview.chromium.org/1905843003/


Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear.
No behavior change.

(also removes very out of date QuicDispatcher constructor comment)

Merge internal change: 119753783
https://codereview.chromium.org/1907773002/


Deprecate FLAGS_quic_sslr_byte_conservation.

Merge internal change: 119678304
https://codereview.chromium.org/1906703002/


Deprecate FLAGS_quic_consolidate_onstreamframe_errors

Merge internal change: 119653892
https://codereview.chromium.org/1906473004/


Add a server push disabled test.

Merge internal change: 119645068
https://codereview.chromium.org/1911653003/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119583512
https://codereview.chromium.org/1909453005/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119581790
https://codereview.chromium.org/1911653002/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119576588
https://codereview.chromium.org/1908723002/


Plumbs new SpdyFramerVisitorInterface method handling through QUIC test
utilities, including the test client and test server. Preparation for CL
103292114.

Merge internal change: 119568788
https://codereview.chromium.org/1910593004/


Fixes QuicSpdyStream::ConsumeHeaderList to prod the sequencer when headers are
consumed. Not yet used in production.

Merge internal change: 119562680
https://codereview.chromium.org/1910483004/


Stop returning unused return value from QuicPacketCreator::CopyToBuffer. No
functional change. Not flag protected.

Merge internal change: 119557380
https://codereview.chromium.org/1897153007/


ignore invalid error code in QuicFramer when process GoAway, ConnectionClose,
RstStream frames to do normal goaway, connection close, and stream reset. Flag
protected by FLAGS_quic_ignore_invalid_error_code.

Merge internal change: 119551887
https://codereview.chromium.org/1904833002/


Adds a DebugString() method to QuicHeaderList.

Merge internal change: 119529330
https://codereview.chromium.org/1907683002/
==========

to

==========
Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Fix a few spurious string allocations in QuicCryptoServerStream and
QuicCryptoStream. No functional change. Not flag protected.

Merge internal change: 119967190
https://codereview.chromium.org/1906803004/


Quic will push urls in x-associate-content and link headers upon
ResponseHeadersComplete(). Change AcceptQuicClient() to start the request
pipeline from PICKING_SERVICE for server push stream. Protected by
FLAGS_quic_server_push.

Implemented server push feature in QUIC. This feature will be enabled by
both flag and connection option "kSPSH".

Merge internal change: 119871679
https://codereview.chromium.org/1905073002/


Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.
No behavior change, not protected.

This is in preparation for gRPC-over-QUIC to use a separate
QuicAlarmFactory for each GrpcQuicConnection. Currently there exists a
single Helper (and after this CL a single AlarmFactory) per Dispatcher,
and this is used to create alarms for all Connections.

gRPC-over-QUIC needs to add per-connection locking to connection alarms
before firing them, and a followup CL will create a different
AlarmFactory for each gRPC-over-QUIC connection, each with its own
mutex (rather than sharing one mutex across the alarms of connections
which is obviously terrible).

Merge internal change: 119778209
https://codereview.chromium.org/1905843003/


Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear.
No behavior change.

(also removes very out of date QuicDispatcher constructor comment)

Merge internal change: 119753783
https://codereview.chromium.org/1907773002/


Deprecate FLAGS_quic_sslr_byte_conservation.

Merge internal change: 119678304
https://codereview.chromium.org/1906703002/


Deprecate FLAGS_quic_consolidate_onstreamframe_errors

Merge internal change: 119653892
https://codereview.chromium.org/1906473004/


Add a server push disabled test.

Merge internal change: 119645068
https://codereview.chromium.org/1911653003/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119583512
https://codereview.chromium.org/1909453005/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119581790
https://codereview.chromium.org/1911653002/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119576588
https://codereview.chromium.org/1908723002/


Plumbs new SpdyFramerVisitorInterface method handling through QUIC test
utilities, including the test client and test server. Preparation for CL
103292114.

Merge internal change: 119568788
https://codereview.chromium.org/1910593004/


Fixes QuicSpdyStream::ConsumeHeaderList to prod the sequencer when headers are
consumed. Not yet used in production.

Merge internal change: 119562680
https://codereview.chromium.org/1910483004/


Stop returning unused return value from QuicPacketCreator::CopyToBuffer. No
functional change. Not flag protected.

Merge internal change: 119557380
https://codereview.chromium.org/1897153007/


ignore invalid error code in QuicFramer when process GoAway, ConnectionClose,
RstStream frames to do normal goaway, connection close, and stream reset. Flag
protected by FLAGS_quic_ignore_invalid_error_code.

Merge internal change: 119551887
https://codereview.chromium.org/1904833002/


Adds a DebugString() method to QuicHeaderList.

Merge internal change: 119529330
https://codereview.chromium.org/1907683002/
==========

[commit-bot: I haz the power, 2016-04-22 06:14:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:44:36]

Description was changed from

==========
Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Fix a few spurious string allocations in QuicCryptoServerStream and
QuicCryptoStream. No functional change. Not flag protected.

Merge internal change: 119967190
https://codereview.chromium.org/1906803004/


Quic will push urls in x-associate-content and link headers upon
ResponseHeadersComplete(). Change AcceptQuicClient() to start the request
pipeline from PICKING_SERVICE for server push stream. Protected by
FLAGS_quic_server_push.

Implemented server push feature in QUIC. This feature will be enabled by
both flag and connection option "kSPSH".

Merge internal change: 119871679
https://codereview.chromium.org/1905073002/


Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.
No behavior change, not protected.

This is in preparation for gRPC-over-QUIC to use a separate
QuicAlarmFactory for each GrpcQuicConnection. Currently there exists a
single Helper (and after this CL a single AlarmFactory) per Dispatcher,
and this is used to create alarms for all Connections.

gRPC-over-QUIC needs to add per-connection locking to connection alarms
before firing them, and a followup CL will create a different
AlarmFactory for each gRPC-over-QUIC connection, each with its own
mutex (rather than sharing one mutex across the alarms of connections
which is obviously terrible).

Merge internal change: 119778209
https://codereview.chromium.org/1905843003/


Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear.
No behavior change.

(also removes very out of date QuicDispatcher constructor comment)

Merge internal change: 119753783
https://codereview.chromium.org/1907773002/


Deprecate FLAGS_quic_sslr_byte_conservation.

Merge internal change: 119678304
https://codereview.chromium.org/1906703002/


Deprecate FLAGS_quic_consolidate_onstreamframe_errors

Merge internal change: 119653892
https://codereview.chromium.org/1906473004/


Add a server push disabled test.

Merge internal change: 119645068
https://codereview.chromium.org/1911653003/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119583512
https://codereview.chromium.org/1909453005/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119581790
https://codereview.chromium.org/1911653002/


Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119576588
https://codereview.chromium.org/1908723002/


Plumbs new SpdyFramerVisitorInterface method handling through QUIC test
utilities, including the test client and test server. Preparation for CL
103292114.

Merge internal change: 119568788
https://codereview.chromium.org/1910593004/


Fixes QuicSpdyStream::ConsumeHeaderList to prod the sequencer when headers are
consumed. Not yet used in production.

Merge internal change: 119562680
https://codereview.chromium.org/1910483004/


Stop returning unused return value from QuicPacketCreator::CopyToBuffer. No
functional change. Not flag protected.

Merge internal change: 119557380
https://codereview.chromium.org/1897153007/


ignore invalid error code in QuicFramer when process GoAway, ConnectionClose,
RstStream frames to do normal goaway, connection close, and stream reset. Flag
protected by FLAGS_quic_ignore_invalid_error_code.

Merge internal change: 119551887
https://codereview.chromium.org/1904833002/


Adds a DebugString() method to QuicHeaderList.

Merge internal change: 119529330
https://codereview.chromium.org/1907683002/
==========

to

==========
Landing Recent QUIC changes until 4/15/2016 17:20 UTC

Fix a few spurious string allocations in QuicCryptoServerStream and
QuicCryptoStream. No functional change. Not flag protected.

Merge internal change: 119967190
https://codereview.chromium.org/1906803004/

Quic will push urls in x-associate-content and link headers upon
ResponseHeadersComplete(). Change AcceptQuicClient() to start the request
pipeline from PICKING_SERVICE for server push stream. Protected by
FLAGS_quic_server_push.

Implemented server push feature in QUIC. This feature will be enabled by
both flag and connection option "kSPSH".

Merge internal change: 119871679
https://codereview.chromium.org/1905073002/

Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.
No behavior change, not protected.

This is in preparation for gRPC-over-QUIC to use a separate
QuicAlarmFactory for each GrpcQuicConnection. Currently there exists a
single Helper (and after this CL a single AlarmFactory) per Dispatcher,
and this is used to create alarms for all Connections.

gRPC-over-QUIC needs to add per-connection locking to connection alarms
before firing them, and a followup CL will create a different
AlarmFactory for each gRPC-over-QUIC connection, each with its own
mutex (rather than sharing one mutex across the alarms of connections
which is obviously terrible).

Merge internal change: 119778209
https://codereview.chromium.org/1905843003/

Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear.
No behavior change.

(also removes very out of date QuicDispatcher constructor comment)

Merge internal change: 119753783
https://codereview.chromium.org/1907773002/

Deprecate FLAGS_quic_sslr_byte_conservation.

Merge internal change: 119678304
https://codereview.chromium.org/1906703002/

Deprecate FLAGS_quic_consolidate_onstreamframe_errors

Merge internal change: 119653892
https://codereview.chromium.org/1906473004/

Add a server push disabled test.

Merge internal change: 119645068
https://codereview.chromium.org/1911653003/

Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119583512
https://codereview.chromium.org/1909453005/

Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119581790
https://codereview.chromium.org/1911653002/

Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is
now just an alias for unique_ptr, so this is a purely textual change.
base/scoped_ptr.h will be removed soon.

Merge internal change: 119576588
https://codereview.chromium.org/1908723002/

Plumbs new SpdyFramerVisitorInterface method handling through QUIC test
utilities, including the test client and test server. Preparation for CL
103292114.

Merge internal change: 119568788
https://codereview.chromium.org/1910593004/

Fixes QuicSpdyStream::ConsumeHeaderList to prod the sequencer when headers are
consumed. Not yet used in production.

Merge internal change: 119562680
https://codereview.chromium.org/1910483004/

Stop returning unused return value from QuicPacketCreator::CopyToBuffer. No
functional change. Not flag protected.

Merge internal change: 119557380
https://codereview.chromium.org/1897153007/

ignore invalid error code in QuicFramer when process GoAway, ConnectionClose,
RstStream frames to do normal goaway, connection close, and stream reset. Flag
protected by FLAGS_quic_ignore_invalid_error_code.

Merge internal change: 119551887
https://codereview.chromium.org/1904833002/

Adds a DebugString() method to QuicHeaderList.

Merge internal change: 119529330
https://codereview.chromium.org/1907683002/

Committed: https://crrev.com/16c74d1d99fc40179bd660f8cbbcab93ec7b4d8d
Cr-Commit-Position: refs/heads/master@{#389035}
==========

[commit-bot: I haz the power, 2016-04-22 19:44:38]

Patchset 5 (id:??) landed as
https://crrev.com/16c74d1d99fc40179bd660f8cbbcab93ec7b4d8d
Cr-Commit-Position: refs/heads/master@{#389035}