Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: net/quic/quic_stream_sequencer_test.cc

Issue 1908103002: Landing Recent QUIC changes until 4/15/2016 17:20 UTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_sequencer.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_sequencer_test.cc
diff --git a/net/quic/quic_stream_sequencer_test.cc b/net/quic/quic_stream_sequencer_test.cc
index ed5511928e3aab9ffa866a04718b896e7f80871e..667c044a3941030baafb1d9a80d62cc4bc453d62 100644
--- a/net/quic/quic_stream_sequencer_test.cc
+++ b/net/quic/quic_stream_sequencer_test.cc
@@ -4,6 +4,9 @@
#include "net/quic/quic_stream_sequencer.h"
+#include <algorithm>
+#include <cstdint>
+#include <memory>
#include <utility>
#include <vector>
@@ -69,7 +72,9 @@ class QuicStreamSequencerTest : public ::testing::Test {
protected:
QuicStreamSequencerTest()
- : connection_(new MockConnection(&helper_, Perspective::IS_CLIENT)),
+ : connection_(new MockConnection(&helper_,
+ &alarm_factory_,
+ Perspective::IS_CLIENT)),
session_(connection_),
stream_(&session_, 1),
sequencer_(new QuicStreamSequencer(&stream_, &clock_)) {}
@@ -146,6 +151,7 @@ class QuicStreamSequencerTest : public ::testing::Test {
}
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
MockConnection* connection_;
MockClock clock_;
MockQuicSpdySession session_;
@@ -563,11 +569,8 @@ TEST_F(QuicStreamSequencerTest, DontAcceptOverlappingFrames) {
sequencer_->OnStreamFrame(frame1);
QuicStreamFrame frame2(kClientDataStreamId1, false, 2, StringPiece("hello"));
- EXPECT_CALL(stream_, CloseConnectionWithDetails(
- FLAGS_quic_consolidate_onstreamframe_errors
- ? QUIC_OVERLAPPING_STREAM_DATA
- : QUIC_EMPTY_STREAM_FRAME_NO_FIN,
- _))
+ EXPECT_CALL(stream_,
+ CloseConnectionWithDetails(QUIC_OVERLAPPING_STREAM_DATA, _))
.Times(1);
sequencer_->OnStreamFrame(frame2);
}
« no previous file with comments | « net/quic/quic_stream_sequencer.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698