native_client_sdk/src/build_tools/test_projects.py - Issue 19079002: Enable pnacl by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/test_projects.py

Issue 19079002: Enable pnacl by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more --enable-pnacl occurrences and code review fixes Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/test_projects.py

diff --git a/native_client_sdk/src/build_tools/test_projects.py b/native_client_sdk/src/build_tools/test_projects.py

index 9c1a0572127a75ce8821281e52805f4c3cc22dc7..4d7524e129dc75317257fa29f5d5d15fcbd0db8f 100755

--- a/native_client_sdk/src/build_tools/test_projects.py

+++ b/native_client_sdk/src/build_tools/test_projects.py

@@ -103,7 +103,7 @@ def GetBrowserTesterCommand(desc, toolchain, config):

args.extend(['--ppapi_plugin', ppapi_plugin])

if toolchain == 'pnacl':

- args.extend(['--browser_flag', '--enable-pnacl'])

+ args.extend(['--browser_flag'])

jvoung (off chromium) 2013/07/24 15:46:58 I don't think you need --browser_flag either. My

sehr 2013/07/24 16:57:02 Yes, what I had would never have worked. Sorry.

url = 'index.html'

url += '?tc=%s&config=%s&test=true' % (toolchain, config)