Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/ppapi/ppapi_test.cc

Issue 19079002: Enable pnacl by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more --enable-pnacl occurrences and code review fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/chrome_switches.h ('K') | « chrome/test/nacl/nacl_browsertest_util.cc ('k') | native_client_sdk/src/build_tools/test_projects.py » ('j') | native_client_sdk/src/build_tools/test_projects.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ppapi/ppapi_test.cc
diff --git a/chrome/test/ppapi/ppapi_test.cc b/chrome/test/ppapi/ppapi_test.cc
index 1953ffec923851e495d2d770a9386fc75cd9d659..7b88d01c0905a04c0be8f61be0aafb508ba8da77 100644
--- a/chrome/test/ppapi/ppapi_test.cc
+++ b/chrome/test/ppapi/ppapi_test.cc
@@ -327,9 +327,8 @@ void PPAPINaClTest::SetUpCommandLine(CommandLine* command_line) {
EXPECT_TRUE(PathService::Get(chrome::FILE_NACL_PLUGIN, &plugin_lib));
EXPECT_TRUE(base::PathExists(plugin_lib));
- // Enable running NaCl outside of the store.
+ // Enable running (non-portable) NaCl outside of the Chrome web store.
command_line->AppendSwitch(switches::kEnableNaCl);
- command_line->AppendSwitch(switches::kEnablePnacl);
command_line->AppendSwitchASCII(switches::kAllowNaClSocketAPI, "127.0.0.1");
command_line->AppendSwitch(switches::kUseFakeDeviceForMediaStream);
command_line->AppendSwitch(switches::kUseFakeUIForMediaStream);
@@ -364,9 +363,8 @@ void PPAPINaClTestDisallowedSockets::SetUpCommandLine(
EXPECT_TRUE(PathService::Get(chrome::FILE_NACL_PLUGIN, &plugin_lib));
EXPECT_TRUE(base::PathExists(plugin_lib));
- // Enable running NaCl outside of the store.
+ // Enable running (non-portable) NaCl outside of the Chrome web store.
command_line->AppendSwitch(switches::kEnableNaCl);
- command_line->AppendSwitch(switches::kEnablePnacl);
}
// Append the correct mode and testcase string
« chrome/common/chrome_switches.h ('K') | « chrome/test/nacl/nacl_browsertest_util.cc ('k') | native_client_sdk/src/build_tools/test_projects.py » ('j') | native_client_sdk/src/build_tools/test_projects.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698