Issue 1907723002: Code completion bug fix, don't suggest optional field formal parameters that are already in the con…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1907723002: Code completion bug fix, don't suggest optional field formal parameters that are already in the con… (Closed)

Created:
4 years, 8 months ago by jwren

Modified:
4 years, 8 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Code completion bug fix, don't suggest optional field formal parameters that are already in the constructor BUG=https://github.com/dart-lang/sdk/issues/26255 R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/bfb5849f44d33626eef24e6c3c429faf38dca2e8

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -4 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/field_formal_contributor.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/field_formal_contributor_test.dart	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

jwren

4 years, 8 months ago (2016-04-21 17:46:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bfb5849f44d33626eef24e6c3c429faf38dca2e8 (presubmit successful).