pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart - Issue 1907723002: Code completion bug fix, don't suggest optional field formal parameters that are already in the con…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart

Issue 1907723002: Code completion bug fix, don't suggest optional field formal parameters that are already in the con… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rebase with master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart

diff --git a/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart

index e2321fba9c71bc41b6e88c9cdb4131ca2ffe1501..a61c9dab59e377e388758d8706e6dc1823bc1e02 100644

--- a/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart

+++ b/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart

@@ -4113,7 +4113,7 @@ class X{}''');

expect(replacementOffset, completionOffset);

expect(replacementLength, 0);

- // Contributed by FieldFormalConstructorContributor

+ // Contributed by FieldFormalContributor

assertNotSuggested('b');

assertNotSuggested('_c');

assertNotSuggested('sb');

@@ -4151,7 +4151,7 @@ class X{}''');

expect(replacementOffset, completionOffset - 1);

expect(replacementLength, 1);

- // Contributed by FieldFormalConstructorContributor

+ // Contributed by FieldFormalContributor

assertNotSuggested('b');

assertNotSuggested('_c');

assertNotSuggested('d');

@@ -4188,7 +4188,7 @@ class X{}''');

expect(replacementOffset, completionOffset);

expect(replacementLength, 1);

- // Contributed by FieldFormalConstructorContributor

+ // Contributed by FieldFormalContributor

assertNotSuggested('b');

assertNotSuggested('_c');

assertNotSuggested('d');

@@ -4226,7 +4226,7 @@ class X{}''');

expect(replacementOffset, completionOffset);

expect(replacementLength, 0);

assertNotSuggested('b');

- // Contributed by FieldFormalConstructorContributor

+ // Contributed by FieldFormalContributor

assertNotSuggested('_c');

assertNotSuggested('d');

assertNotSuggested('_e');

« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/field_formal_contributor_test.dart ('k') | no next file » | no next file with comments »