Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 190763008: Only notify V8 once per timezone change (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Only notify V8 once per timezone change The timezone is a global property. No need to notify V8 for every single frame. As a side-effect, we don't have a race with context creation. BUG=348856 R=marja@chromium.org, kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-10 10:34:33 UTC) #1
marja
lgtm, I believe this is the right fix.
6 years, 9 months ago (2014-03-10 10:36:19 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 9 months ago (2014-03-10 10:43:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/190763008/1
6 years, 9 months ago (2014-03-10 10:43:11 UTC) #4
jochen (gone - plz use gerrit)
(note that the IPC message should actually be a control message and be handled by ...
6 years, 9 months ago (2014-03-10 11:03:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 12:00:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-10 12:00:03 UTC) #7
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 9 months ago (2014-03-10 12:49:48 UTC) #8
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r255928 (presubmit successful).
6 years, 9 months ago (2014-03-10 12:56:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/190763008/1
6 years, 9 months ago (2014-03-10 12:59:49 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 12:59:51 UTC) #11
Message was sent while issue was closed.
Failed to apply patch for content/renderer/render_frame_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/render_frame_impl.cc
  Hunk #1 FAILED at 592.
  1 out of 1 hunk FAILED -- saving rejects to file
content/renderer/render_frame_impl.cc.rej

Patch:       content/renderer/render_frame_impl.cc
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc
b/content/renderer/render_frame_impl.cc
index
6200b3480aa2e5a38f255e3c412fc817cb30a73f..99518d9b26a4649c8214f6055d9e0387167901a3
100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -592,7 +592,7 @@ void RenderFrameImpl::OnNavigate(const
FrameMsg_Navigate_Params& params) {
     // We refresh timezone when a view is swapped in since timezone
     // can get out of sync when the system timezone is updated while
     // the view is swapped out.
-    RenderViewImpl::NotifyTimezoneChange(render_view_->webview()->mainFrame());
+    RenderViewImpl::NotifyTimezoneChange();
 
     render_view_->SetSwappedOut(false);
     is_swapped_out_ = false;

Powered by Google App Engine
This is Rietveld 408576698