Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: content/renderer/render_view_impl.cc

Issue 190763008: Only notify V8 once per timezone change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 296fce9e06f6a6751b3725844e23a1704727bbc1..d12b0eec19add34c0e888c19b4b55f7173662cd6 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -379,13 +379,8 @@ Referrer RenderViewImpl::GetReferrerFromRequest(
}
// static
-void RenderViewImpl::NotifyTimezoneChange(blink::WebFrame* frame) {
- v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
- v8::Context::Scope context_scope(frame->mainWorldScriptContext());
+void RenderViewImpl::NotifyTimezoneChange() {
v8::Date::DateTimeConfigurationChangeNotification(v8::Isolate::GetCurrent());
- blink::WebFrame* child = frame->firstChild();
- for (; child; child = child->nextSibling())
- NotifyTimezoneChange(child);
}
// static
@@ -3778,8 +3773,7 @@ void RenderViewImpl::OnUpdateWebPreferences(const WebPreferences& prefs) {
}
void RenderViewImpl::OnUpdateTimezone() {
- if (webview())
- NotifyTimezoneChange(webview()->mainFrame());
+ NotifyTimezoneChange();
}
void RenderViewImpl::OnEnumerateDirectoryResponse(
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698