DescriptionRevert of [tracing] Turn StackFrame into struct. (patchset #5 id:80001 of https://codereview.chromium.org/1891543003/ )
Reason for revert:
Broke build on Windows x64 (warning was treated as error): heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>
> BUG=602701
TBR=primiano@chromium.org,ssid@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602701
Committed: https://crrev.com/7e308e6f283b287ad0e2229e8d8adb865a7542b6
Cr-Commit-Position: refs/heads/master@{#388558}
Patch Set 1 #Messages
Total messages: 10 (3 generated)
|