Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1907593002: Revert of [tracing] Turn StackFrame into struct. (Closed)

Created:
4 years, 8 months ago by Dmitry Skiba
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Turn StackFrame into struct. (patchset #5 id:80001 of https://codereview.chromium.org/1891543003/ ) Reason for revert: Broke build on Windows x64 (warning was treated as error): heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data Original issue's description: > [tracing] Turn StackFrame into struct. > > This change turns StackFrame (aka const char*) into a struct and > introduces 'type' field which controls how stack frame is formatted > when it's written to trace file. As an example, thread name, which > previously was just a string like any other function name, is now > formatted as '[Thread: %s]'. > > More stack frame types will be added in the future, for example > native allocation tracing will add 'program counter' type. > > BUG=602701 TBR=primiano@chromium.org,ssid@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602701 Committed: https://crrev.com/7e308e6f283b287ad0e2229e8d8adb865a7542b6 Cr-Commit-Position: refs/heads/master@{#388558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -214 lines) Patch
M base/trace_event/heap_profiler_allocation_context.h View 2 chunks +25 lines, -45 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context.cc View 2 chunks +19 lines, -28 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.cc View 3 chunks +19 lines, -17 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc View 11 chunks +39 lines, -39 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register_unittest.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M base/trace_event/heap_profiler_heap_dump_writer.cc View 2 chunks +15 lines, -9 lines 0 comments Download
M base/trace_event/heap_profiler_heap_dump_writer_unittest.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M base/trace_event/heap_profiler_stack_frame_deduplicator.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M base/trace_event/heap_profiler_stack_frame_deduplicator_unittest.cc View 3 chunks +17 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dmitry Skiba
Created Revert of [tracing] Turn StackFrame into struct.
4 years, 8 months ago (2016-04-20 19:55:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907593002/1
4 years, 8 months ago (2016-04-20 19:56:05 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-20 19:56:06 UTC) #4
Primiano Tucci (use gerrit)
lgtm
4 years, 8 months ago (2016-04-20 19:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907593002/1
4 years, 8 months ago (2016-04-20 19:59:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 20:00:08 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e308e6f283b287ad0e2229e8d8adb865a7542b6
Cr-Commit-Position: refs/heads/master@{#388558}

Powered by Google App Engine
This is Rietveld 408576698