Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1907523002: [ios-ninja] Support xctests for devices in release. (Closed)

Created:
4 years, 8 months ago by justincohen
Modified:
4 years, 8 months ago
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

[ios-ninja] Support xctests in devices in release. When testing on device, Xcode xctest's are copied into $TEST_HOST with two special frameworks. BUG= R=sdefresne@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/4cf07e8d616739f6484e46c9359b2a35196b2585

Patch Set 1 #

Patch Set 2 : Fix plugins #

Patch Set 3 : Change codesign to preserve entitlements #

Patch Set 4 : Fix preserve check #

Patch Set 5 : Simpler mac_tool changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -12 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +2 lines, -1 line 0 comments Download
M pylib/gyp/mac_tool.py View 1 2 3 4 2 chunks +9 lines, -6 lines 0 comments Download
M pylib/gyp/xcode_emulation.py View 1 2 3 4 3 chunks +46 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
justincohen
PTAL!
4 years, 8 months ago (2016-04-20 21:08:56 UTC) #3
sdefresne
lg but I think we really need a design document to list every thing that ...
4 years, 8 months ago (2016-04-21 16:56:39 UTC) #4
justincohen
What would a design doc entail? The steps are basically 'do what xcode does'. As ...
4 years, 8 months ago (2016-04-24 20:35:47 UTC) #5
justincohen
PTAL!
4 years, 8 months ago (2016-04-24 20:36:00 UTC) #6
sdefresne
On 2016/04/24 at 20:35:47, justincohen wrote: > What would a design doc entail? The steps ...
4 years, 8 months ago (2016-04-25 16:13:49 UTC) #7
rohitrao (ping after 24h)
On 2016/04/25 16:13:49, sdefresne wrote: > On 2016/04/24 at 20:35:47, justincohen wrote: > > What ...
4 years, 8 months ago (2016-04-25 16:17:11 UTC) #8
justincohen
Committed patchset #5 (id:80001) manually as 4cf07e8d616739f6484e46c9359b2a35196b2585 (presubmit successful).
4 years, 8 months ago (2016-04-25 22:11:24 UTC) #10
justincohen
4 years, 8 months ago (2016-04-26 12:42:20 UTC) #11
Message was sent while issue was closed.
sdefresne:  See small doc listing changes here:
https://docs.google.com/document/d/1IF-z6u0z55K7Ub3MVLttP6ZpZEp9gT7fk0qhx1kCR...

Powered by Google App Engine
This is Rietveld 408576698