pylib/gyp/generator/ninja.py - Issue 1907523002: [ios-ninja] Support xctests for devices in release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja.py

Issue 1907523002: [ios-ninja] Support xctests for devices in release. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Simpler mac_tool changes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/ninja.py

diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py

index edac48dfca40ec31028eee497353f47c7792d341..9cfc7060b5c918a68bb7e8540d573a04eb3a7682 100644

--- a/pylib/gyp/generator/ninja.py

+++ b/pylib/gyp/generator/ninja.py

@@ -1369,7 +1369,8 @@ class NinjaWriter(object):

is_command_start=not package_framework)

if package_framework and not is_empty:

if spec['type'] == 'shared_library' and self.xcode_settings.isIOS:

- self.ninja.build(output, 'package_ios_framework', mac_bundle_depends)

+ self.ninja.build(output, 'package_ios_framework', mac_bundle_depends,

+ variables=variables)

else:

variables.append(('version', self.xcode_settings.GetFrameworkVersion()))

self.ninja.build(output, 'package_framework', mac_bundle_depends,

« no previous file with comments | « no previous file | pylib/gyp/mac_tool.py » ('j') | no next file with comments »