third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html - Issue 1907443007: Use promises in notifications tests and enable controlling the page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

Issue 1907443007: Use promises in notifications tests and enable controlling the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Address peter's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html ('k') | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-click.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

index 5110ca78a6e33dbe9845364daeaa854f77f1d72a..72c6c46c25d33a48592ddeb1ae2f2c451fca8438 100644

--- a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

@@ -11,7 +11,7 @@

// Tests that serviceWorkerRegistration.showNotification throws a

// TypeError if NotificationOptions.actions is set incorrectly.

- var script = 'resources/instrumentation-service-worker.js';

+ var script = 'instrumentation-service-worker.js';

testRunner.setPermission('notifications', 'granted', location.origin, location.origin);