content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java - Issue 1907443004: Android: SELECT popups should not send notifications if a renderer asked to close it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

Issue 1907443004: Android: SELECT popups should not send notifications if a renderer asked to close it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Put if-return in one line Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java ('k') | third_party/WebKit/public/web/WebExternalPopupMenu.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

index 707ad2c04c7111e1a4dc9b16507a94a18f67decf..b5989cf533886446ab9f9ee7d683e622f2438953 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

@@ -39,7 +39,7 @@ public class SelectPopupDropdown implements SelectPopup {

@Override

public void onItemClick(AdapterView<?> parent, View view, int position, long id) {

notifySelection(new int[] {position});

- hide();

+ hide(false);

}

});

if (selected.length > 0) {

@@ -81,8 +81,13 @@ public class SelectPopupDropdown implements SelectPopup {

}

@Override

- public void hide() {

- mDropdownPopupWindow.dismiss();

- notifySelection(null);

+ public void hide(boolean sendsCancelMessage) {

+ if (sendsCancelMessage) {

+ mDropdownPopupWindow.dismiss();

+ notifySelection(null);

+ } else {

+ mSelectionNotified = true;

+ mDropdownPopupWindow.dismiss();

+ }

}