third_party/WebKit/Source/core/layout/LayoutFlowThread.h - Issue 1907443003: Translate flow thread coords to the nearest enclosing coord space when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

Issue 1907443003: Translate flow thread coords to the nearest enclosing coord space when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a unit test too. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/multicol-nested-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h » ('j') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

index 08d43045b00b1a0e2a24f8181cf58bd8c1c4f66b..e0bf6709615f970bf692e256b4f9f1ab73a87b82 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

@@ -105,11 +105,7 @@ public:

// rectangles are completely physical in terms of writing mode.

LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox) const;

- LayoutPoint flowThreadPointToVisualPoint(const LayoutPoint& flowThreadPoint) const

- {

- return flowThreadPoint + columnOffset(flowThreadPoint);

- }

+ virtual LayoutPoint flowThreadPointToVisualPoint(const LayoutPoint& flowThreadPoint) const = 0;

virtual LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) const = 0;

virtual LayoutMultiColumnSet* columnSetAtBlockOffset(LayoutUnit) const = 0;