Introduce approximate mode for StandardFrame::Summarize.

Introduce approximate mode for StandardFrame::Summarize.

The approximate mode enables taking an approximate stack trace from GC,
where the top frames might be missing if inlined. Note that in that case,
the frame summary will refer to optimized code, so it will not be possible
to take source position. (The user of the summary will have to handle the
case frame_summary.abstract_code()->kind() == AbstractCode::OPTIMIZED_CODE
specially.)

Committed: https://crrev.com/fcbe95c8dc3cd738ac2643a2f3488609de49addd
Cr-Commit-Position: refs/heads/master@{#35728}

[Jarin, 2016-04-20 08:42:41]

Description was changed from

==========
Introduce approximate mode for StandardFrame::Summarize.

The approximate mode enables taking an approximate stack trace from GC,
where the top frames might be missing if inlined. Note that in that case,
the frame summary will refer to optimized code, so it will not be possible
to take source position. (The user of the summary will have to handle the
case frame_summary.abstract_code()->kind() == AbstractCode::OPTIMIZED_CODE
specially.)
==========

to

==========
Introduce approximate mode for StandardFrame::Summarize.

The approximate mode enables taking an approximate stack trace from GC,
where the top frames might be missing if inlined. Note that in that case,
the frame summary will refer to optimized code, so it will not be possible
to take source position. (The user of the summary will have to handle the
case frame_summary.abstract_code()->kind() == AbstractCode::OPTIMIZED_CODE
specially.)
==========

[Jarin, 2016-04-20 08:42:41]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2016-04-20 08:45:01]

Could you take a look, please?

[Michael Starzinger, 2016-04-22 11:19:06]

LGTM.

https://codereview.chromium.org/1907443002/diff/20001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1907443002/diff/20001/src/frames.cc#newcode1180
src/frames.cc:1180: DCHECK_NOT_NULL(data);
nit: Maybe even "DCHECK(data != nullptr && deopt_index !=
Safepoint::kNoDeoptimizationIndex)" here. Also, there is another call-site in
the TranslatedState constructor, do you think it makes sense to have the same
assert there?

[Jarin, 2016-04-22 12:27:12]

https://codereview.chromium.org/1907443002/diff/20001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1907443002/diff/20001/src/frames.cc#newcode1180
src/frames.cc:1180: DCHECK_NOT_NULL(data);
On 2016/04/22 11:19:06, Michael Starzinger wrote:
> nit: Maybe even "DCHECK(data != nullptr && deopt_index !=
> Safepoint::kNoDeoptimizationIndex)" here. Also, there is another call-site in
> the TranslatedState constructor, do you think it makes sense to have the same
> assert there?

Done.

[Jarin, 2016-04-22 12:27:18]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-04-22 12:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1907443002/#ps40001
(title: "Addressed review feedback")

[commit-bot: I haz the power, 2016-04-22 12:27:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907443002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907443002/40001

[commit-bot: I haz the power, 2016-04-22 12:37:29]

Description was changed from

==========
Introduce approximate mode for StandardFrame::Summarize.

The approximate mode enables taking an approximate stack trace from GC,
where the top frames might be missing if inlined. Note that in that case,
the frame summary will refer to optimized code, so it will not be possible
to take source position. (The user of the summary will have to handle the
case frame_summary.abstract_code()->kind() == AbstractCode::OPTIMIZED_CODE
specially.)
==========

to

==========
Introduce approximate mode for StandardFrame::Summarize.

The approximate mode enables taking an approximate stack trace from GC,
where the top frames might be missing if inlined. Note that in that case,
the frame summary will refer to optimized code, so it will not be possible
to take source position. (The user of the summary will have to handle the
case frame_summary.abstract_code()->kind() == AbstractCode::OPTIMIZED_CODE
specially.)
==========

[commit-bot: I haz the power, 2016-04-22 12:37:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:15:35]

Description was changed from

==========
Introduce approximate mode for StandardFrame::Summarize.

The approximate mode enables taking an approximate stack trace from GC,
where the top frames might be missing if inlined. Note that in that case,
the frame summary will refer to optimized code, so it will not be possible
to take source position. (The user of the summary will have to handle the
case frame_summary.abstract_code()->kind() == AbstractCode::OPTIMIZED_CODE
specially.)
==========

to

==========
Introduce approximate mode for StandardFrame::Summarize.

The approximate mode enables taking an approximate stack trace from GC,
where the top frames might be missing if inlined. Note that in that case,
the frame summary will refer to optimized code, so it will not be possible
to take source position. (The user of the summary will have to handle the
case frame_summary.abstract_code()->kind() == AbstractCode::OPTIMIZED_CODE
specially.)

Committed: https://crrev.com/fcbe95c8dc3cd738ac2643a2f3488609de49addd
Cr-Commit-Position: refs/heads/master@{#35728}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:36]

Patchset 3 (id:??) landed as
https://crrev.com/fcbe95c8dc3cd738ac2643a2f3488609de49addd
Cr-Commit-Position: refs/heads/master@{#35728}