src/deoptimizer.cc - Issue 1907443002: Introduce approximate mode for StandardFrame::Summarize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/deoptimizer.cc

Issue 1907443002: Introduce approximate mode for StandardFrame::Summarize. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed review feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/deoptimizer.cc

diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc

index 842b070b14ff7be17efd20c4dbbe9a9a04397e8a..bf7cd935f6ef29a7422e97b4cadb9fdcc5d42b85 100644

--- a/src/deoptimizer.cc

+++ b/src/deoptimizer.cc

@@ -3383,6 +3383,7 @@ TranslatedState::TranslatedState(JavaScriptFrame* frame)

int deopt_index = Safepoint::kNoDeoptimizationIndex;

DeoptimizationInputData* data =

static_cast<OptimizedFrame*>(frame)->GetDeoptimizationData(&deopt_index);

+ DCHECK(data != nullptr && deopt_index != Safepoint::kNoDeoptimizationIndex);

TranslationIterator it(data->TranslationByteArray(),

data->TranslationIndex(deopt_index)->value());

Init(frame->fp(), &it, data->LiteralArray(), nullptr /* registers */,

« no previous file with comments | « no previous file | src/frames.h » ('j') | no next file with comments »