Issue 190743002: Measure private dirty memory on OS that have /proc (e.g. Linux).

Issue 190743002: Measure private dirty memory on OS that have /proc (e.g. Linux). (Closed)

Created:
6 years, 9 months ago by Philippe

Modified:
6 years, 9 months ago

Reviewers:
bulach, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Measure private dirty memory on OS that have /proc (e.g. Linux). Note that private dirty is already measured on Android. BUG=347919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255913

Patch Set 1 #

Patch Set 2 : Add unit test #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1082 lines, -2 lines)			Patch
M	tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend.py	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
A	tools/telemetry/unittest_data/smaps	View	1	1 chunk	+1065 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Philippe

Hi guys, I needed to evaluate the impact of a change on platforms where discardable ...

6 years, 9 months ago (2014-03-07 12:39:55 UTC) #1

bulach

lgtm, thanks! ...since tony just sent the announcement ;) mind adding a test please? https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py&sq=package:chromium

6 years, 9 months ago (2014-03-07 15:04:28 UTC) #2

tonyg

On 2014/03/07 15:04:28, bulach wrote: > lgtm, thanks! ...since tony just sent the announcement ;) ...

6 years, 9 months ago (2014-03-07 15:41:04 UTC) #3

Philippe

Thanks guys! I added a unit test in the last patch set :)

6 years, 9 months ago (2014-03-10 09:21:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/190743002/40001

6 years, 9 months ago (2014-03-10 09:22:25 UTC) #6

Message was sent while issue was closed.

Change committed as 255913

Expand Messages | Collapse Messages