tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py - Issue 190743002: Measure private dirty memory on OS that have /proc (e.g. Linux).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py

Issue 190743002: Measure private dirty memory on OS that have /proc (e.g. Linux). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add unit test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend.py ('k') | tools/telemetry/unittest_data/smaps » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py b/tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py

index bd3ab230aeb2f5fb278e25a66c51435469da60db..81069b841cf3dec57ea2888aa99cd33d5f8d33f1 100644

--- a/tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/proc_supporting_platform_backend_unittest.py

@@ -39,8 +39,12 @@ class ProcSupportingPlatformBackendTest(unittest.TestCase):

backend.SetMockFile(

'/proc/1/status',

open(os.path.join(util.GetUnittestDataDir(), 'status')).read())

+ backend.SetMockFile(

+ '/proc/1/smaps',

+ open(os.path.join(util.GetUnittestDataDir(), 'smaps')).read())

result = backend.GetMemoryStats(1)

- self.assertEquals(result, {'VM': 1025978368,

+ self.assertEquals(result, {'PrivateDirty': 5324800,

+ 'VM': 1025978368,

'VMPeak': 1050099712,

'WorkingSetSize': 84000768,

'WorkingSetSizePeak': 144547840})

@@ -57,8 +61,12 @@ class ProcSupportingPlatformBackendTest(unittest.TestCase):