Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1907373002: Revert of Add function to trace stack using frame pointers. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add function to trace stack using frame pointers. (patchset #8 id:140001 of https://codereview.chromium.org/1879073002/ ) Reason for revert: Failure on Linux ChromeOS MSan Tests: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/9050 See: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/9050/steps/base_unittests%20on%20Ubuntu-12.04/logs/stdio Original issue's description: > Add function to trace stack using frame pointers. > > For memory-infra we need fast stack traces to implement allocation > tracing (see https://goo.gl/DFoqfi). StackTrace class uses unwinding > and is too slow. This change adds a function that uses frame pointers > to walk the stack. > > The function supports x86, x64 and arm (but not thumb) architectures > on POSIX platforms. > > BUG=602701 TBR=thakis@chromium.org,bcwhite@chromium.org,primiano@chromium.org,dskiba@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602701 Committed: https://crrev.com/9cf919380c57cb39a2d5b7a24120d575fbe7258a Cr-Commit-Position: refs/heads/master@{#389149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -113 lines) Patch
M base/debug/stack_trace.h View 2 chunks +0 lines, -22 lines 0 comments Download
M base/debug/stack_trace.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M base/debug/stack_trace_unittest.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
apacible
Created Revert of Add function to trace stack using frame pointers.
4 years, 8 months ago (2016-04-22 17:17:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907373002/1
4 years, 8 months ago (2016-04-22 17:17:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 17:18:09 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:49:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cf919380c57cb39a2d5b7a24120d575fbe7258a
Cr-Commit-Position: refs/heads/master@{#389149}

Powered by Google App Engine
This is Rietveld 408576698