Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3179)

Unified Diff: base/debug/stack_trace.h

Issue 1907373002: Revert of Add function to trace stack using frame pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/debug/stack_trace.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/stack_trace.h
diff --git a/base/debug/stack_trace.h b/base/debug/stack_trace.h
index 23e7b5164b63472409a92e992c5c1095dfa48d26..07e119a16b4a255dc443acf28c37d0c5cefa25c2 100644
--- a/base/debug/stack_trace.h
+++ b/base/debug/stack_trace.h
@@ -20,14 +20,6 @@
#if defined(OS_WIN)
struct _EXCEPTION_POINTERS;
struct _CONTEXT;
-#endif
-
-#if defined(OS_POSIX) && ( \
- defined(__i386__) || defined(__x86_64__) || \
- (defined(__arm__) && !defined(__thumb__)))
-#define HAVE_TRACE_STACK_FRAME_POINTERS 1
-#else
-#define HAVE_TRACE_STACK_FRAME_POINTERS 0
#endif
namespace base {
@@ -101,20 +93,6 @@
size_t count_;
};
-#if HAVE_TRACE_STACK_FRAME_POINTERS
-// Traces the stack by using frame pointers. This function is faster but less
-// reliable than StackTrace. It should work for debug and profiling builds,
-// but not for release builds (although there are some exceptions).
-//
-// Writes at most |max_depth| frames (instruction pointers) into |out_trace|
-// after skipping |skip_initial| frames. Note that the function itself is not
-// added to the trace so |skip_initial| should be 0 in most cases.
-// Returns number of frames written.
-BASE_EXPORT size_t TraceStackFramePointers(const void** out_trace,
- size_t max_depth,
- size_t skip_initial);
-#endif // HAVE_TRACE_STACK_FRAME_POINTERS
-
namespace internal {
#if defined(OS_POSIX) && !defined(OS_ANDROID)
« no previous file with comments | « no previous file | base/debug/stack_trace.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698