third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js ('K') | « third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

index 09967447427a68af5723c9cc030d61dbc35fe1f7..59ad119a1f0aace7bd5c6c276f3616ea475d4dc8 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

@@ -333,7 +333,9 @@ WebInspector.CallStackSidebarPane.prototype = {

_selectNextVisibleCallFrame: function(index, backward)

{

+ /* eslint-disable yoda */

pfeldman 2016/04/22 14:22:07 We can rewrite it to make lint happy - I also can'

paulirish 2016/04/22 18:28:50 being addressed by kozyatinskiy. I'll remove the a

while (0 <= index && index < this.callFrames.length) {

+ /* eslint-enable yoda */

var callFrame = this.callFrames[index];

if (!callFrame.isHidden() && !callFrame.isLabel() && !callFrame._asyncCallFrame) {

this._callFrameSelected(callFrame);