third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js ('K') | « third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js ('k') | third_party/WebKit/Source/devtools/front_end/platform/utilities.js » ('j') | third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

diff --git a/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js b/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

index 90abdf26d69e9ab63c44643ebbef430725fd8e5b..30f588fc3b89e99ca73488a8dc0f4bbc1b3c20ce 100644

--- a/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

+++ b/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

@@ -186,7 +186,7 @@ Element.prototype.isScrolledToBottom = function()

function removeSubsequentNodes(fromNode, toNode)

{

- for (var node = fromNode; node && node !== toNode; ) {

+ for (var node = fromNode; node && node !== toNode;) {

paulirish 2016/04/22 09:50:50 This is the only change I feel bad about.

var nodeToRemove = node;

node = node.nextSibling;

nodeToRemove.remove();

@@ -746,7 +746,7 @@ Node.prototype.appendChildren = function(var_args)

Node.prototype.deepTextContent = function()

{

- return this.childTextNodes().map(function (node) { return node.textContent; }).join("");

+ return this.childTextNodes().map(function(node) { return node.textContent; }).join("");

}

/**