Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 190723003: Revert 255602 "Cast: Cap max receiver log size per rtcp packet t..." (Closed)

Created:
6 years, 9 months ago by mef
Modified:
6 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255602 "Cast: Cap max receiver log size per rtcp packet t..." Broke RtcpReceiverReportWithOversizedFrameLog and RtcpReceiverReportWithTooManyLogFrames tests > Cast: Cap max receiver log size per rtcp packet to 200 bytes. > > This is a short term fix to hopefully reduce the effects of packets > queueing up on the receiver side. Previously we try fill up the RTCP > packet with as many receiver log as possible so we can have redundancy. > The redundancy that has been observed was more than 30 per message, and > we don't need this much redundancy. 200 is a good number where each > log message will be sent with redundancy of around 2-3, without losing > too many (< 1%) messages, assuming default rtcp interval settings. > That's fine because we don't need the logs to be completely reliable. > > > BUG=349265 > > Review URL: https://codereview.chromium.org/189423002 TBR=imcheng@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M trunk/src/media/cast/rtcp/rtcp_sender.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mef
6 years, 9 months ago (2014-03-07 14:35:11 UTC) #1
mef
6 years, 9 months ago (2014-03-07 14:35:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255611 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698