Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 189423002: Cast: Cap max receiver log size per rtcp packet to 200 bytes. (Closed)

Created:
6 years, 9 months ago by imcheng
Modified:
6 years, 9 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Cap max receiver log size per rtcp packet to 200 bytes. This is a short term fix to hopefully reduce the effects of packets queueing up on the receiver side. Previously we try fill up the RTCP packet with as many receiver log as possible so we can have redundancy. The redundancy that has been observed was more than 30 per message, and we don't need this much redundancy. 200 is a good number where each log message will be sent with redundancy of around 2-3, without losing too many (< 1%) messages, assuming default rtcp interval settings. That's fine because we don't need the logs to be completely reliable. BUG=349265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255602

Patch Set 1 #

Patch Set 2 : Reland patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M media/cast/rtcp/rtcp_sender.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp_sender_unittest.cc View 1 3 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
imcheng
6 years, 9 months ago (2014-03-06 23:44:57 UTC) #1
Alpha Left Google
On 2014/03/06 23:44:57, imcheng1 wrote: LGTM.
6 years, 9 months ago (2014-03-07 00:52:36 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 9 months ago (2014-03-07 00:52:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189423002/1
6 years, 9 months ago (2014-03-07 01:01:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 03:56:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 03:56:29 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 9 months ago (2014-03-07 04:38:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189423002/1
6 years, 9 months ago (2014-03-07 04:39:08 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 10:38:01 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=277204
6 years, 9 months ago (2014-03-07 10:38:02 UTC) #10
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 9 months ago (2014-03-07 10:41:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189423002/1
6 years, 9 months ago (2014-03-07 10:42:17 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 13:14:52 UTC) #13
Message was sent while issue was closed.
Change committed as 255602

Powered by Google App Engine
This is Rietveld 408576698