Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906973002: Convert //components/bookmarks from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, noyau+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/bookmarks from scoped_ptr to std::unique_ptr BUG=554298 R=sky@chromium.org Committed: https://crrev.com/acd3f5279c9bc0c73f25976e1cdfa72f43309dba Cr-Commit-Position: refs/heads/master@{#388924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -159 lines) Patch
M components/bookmarks/browser/bookmark_codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_codec_unittest.cc View 14 chunks +41 lines, -33 lines 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_index_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 6 chunks +11 lines, -10 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 8 chunks +15 lines, -20 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/bookmarks/browser/bookmark_node.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_storage.h View 5 chunks +7 lines, -7 lines 0 comments Download
M components/bookmarks/browser/bookmark_storage.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/bookmarks/browser/bookmark_undo_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_undo_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils_unittest.cc View 17 chunks +21 lines, -21 lines 0 comments Download
M components/bookmarks/managed/managed_bookmark_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/bookmarks/managed/managed_bookmark_service.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M components/bookmarks/test/test_bookmark_client.h View 2 chunks +5 lines, -4 lines 0 comments Download
M components/bookmarks/test/test_bookmark_client.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
4 years, 8 months ago (2016-04-21 21:07:37 UTC) #3
sky
LGTM
4 years, 8 months ago (2016-04-21 22:18:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906973002/1
4 years, 8 months ago (2016-04-21 22:20:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 22:30:56 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:40:31 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/acd3f5279c9bc0c73f25976e1cdfa72f43309dba
Cr-Commit-Position: refs/heads/master@{#388924}

Powered by Google App Engine
This is Rietveld 408576698