components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm - Issue 1906973002: Convert //components/bookmarks from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

Issue 1906973002: Convert //components/bookmarks from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_node_data_unittest.cc ('k') | components/bookmarks/browser/bookmark_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

diff --git a/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm b/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

index c37f806ea1cb20f5716bfa266b9c8f161dc97a9f..ac62051013c7e4b8072ca031029c4557ba4394e9 100644

--- a/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

+++ b/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

@@ -56,7 +56,7 @@ void ConvertPlistToElements(NSArray* input,

NSUInteger len = [input count];

for (NSUInteger i = 0; i < len; ++i) {

NSDictionary* pboardBookmark = [input objectAtIndex:i];

- scoped_ptr<BookmarkNode> new_node(new BookmarkNode(GURL()));

+ std::unique_ptr<BookmarkNode> new_node(new BookmarkNode(GURL()));

int64_t node_id =

[[pboardBookmark objectForKey:kChromiumBookmarkId] longLongValue];

new_node->set_id(node_id);

« no previous file with comments | « components/bookmarks/browser/bookmark_node_data_unittest.cc ('k') | components/bookmarks/browser/bookmark_storage.h » ('j') | no next file with comments »