Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906883002: [Do Not Commit] Migrate vr service from content/renderer/ to WebKit/platform/ (Closed)

Created:
4 years, 8 months ago by bajones
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, dglazkov+blink, blink-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org, darin (slow to review), ben+mojo_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Do Not Commit] Migrate vr service from content/renderer/ to WebKit/platform/ Experiementing with ways to make the WebVR interface cleaner when the mojo service is moved into public/platform/ BUG=593607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -554 lines) Patch
M content/browser/DEPS View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/vr/android/cardboard/cardboard_vr_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/vr/android/cardboard/cardboard_vr_device.cc View 7 chunks +18 lines, -18 lines 0 comments Download
M content/browser/vr/vr_device.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/vr/vr_device_manager.h View 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/vr/vr_device_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/vr_service.mojom View 1 chunk +0 lines, -73 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -13 lines 0 comments Download
D content/renderer/vr/vr_dispatcher.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/renderer/vr/vr_dispatcher.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D content/renderer/vr/vr_type_converters.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/renderer/vr/vr_type_converters.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.h View 2 chunks +22 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 3 chunks +75 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRHardwareUnit.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/modules/vr/VRTypeConverters.h View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRTypeConverters.cpp View 1 chunk +150 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/public/platform/modules/vr/WebVRClient.h View 1 chunk +0 lines, -31 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/vr/vr_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
bajones
4 years, 7 months ago (2016-05-04 15:24:33 UTC) #1 
Description was changed from

==========
[Do Not Commit] Migrate vr service from content/renderer/ to WebKit/platform/

Experiementing with ways to make the WebVR interface cleaner when the mojo
service is moved into public/platform/

BUG=593607
==========

to

==========
[Do Not Commit] Migrate vr service from content/renderer/ to WebKit/platform/

Experiementing with ways to make the WebVR interface cleaner when the mojo
service is moved into public/platform/

BUG=593607
==========

Powered by Google App Engine
This is Rietveld 408576698