Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: src/compiler/access-builder.cc

Issue 1906823002: Move of the type feedback vector to the closure. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index d4187faaaddd512d3f6bf4eb51d16d2515e425cc..01b7efc4c23b32f7229519991d6e7bc4583cf86a 100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -100,14 +100,6 @@ FieldAccess AccessBuilder::ForJSFunctionSharedFunctionInfo() {
// static
-FieldAccess AccessBuilder::ForJSFunctionLiterals() {
- FieldAccess access = {
- kTaggedBase, JSFunction::kLiteralsOffset, Handle<Name>(),
- Type::Internal(), MachineType::AnyTagged(), kPointerWriteBarrier};
- return access;
-}
-
-// static
FieldAccess AccessBuilder::ForJSFunctionCodeEntry() {
FieldAccess access = {kTaggedBase,
JSFunction::kCodeEntryOffset,
@@ -419,19 +411,22 @@ FieldAccess AccessBuilder::ForPropertyCellValue(Type* type) {
return access;
}
+// static
+FieldAccess AccessBuilder::ForJSFunctionLiterals() {
Michael Starzinger 2016/05/10 13:47:20 nit: Please keep these in the same order as in the
mvstanton 2016/05/24 16:31:49 Done.
+ FieldAccess access = {
+ kTaggedBase, JSFunction::kLiteralsOffset, Handle<Name>(),
+ Type::Internal(), MachineType::AnyTagged(), kPointerWriteBarrier};
+ return access;
+}
// static
-FieldAccess AccessBuilder::ForSharedFunctionInfoTypeFeedbackVector() {
- FieldAccess access = {kTaggedBase,
- SharedFunctionInfo::kFeedbackVectorOffset,
- Handle<Name>(),
- Type::Any(),
- MachineType::AnyTagged(),
+FieldAccess AccessBuilder::ForLiteralsTypeFeedbackVector() {
+ FieldAccess access = {kTaggedBase, LiteralsArray::kFeedbackVectorOffset,
+ Handle<Name>(), Type::Any(), MachineType::AnyTagged(),
kPointerWriteBarrier};
return access;
}
-
// static
ElementAccess AccessBuilder::ForFixedArrayElement() {
ElementAccess access = {kTaggedBase, FixedArray::kHeaderSize, Type::Tagged(),

Powered by Google App Engine
This is Rietveld 408576698