Move of the type feedback vector to the closure.

src/compiler/access-builder.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
 
 #include "src/contexts.h"
 #include "src/frames.h"
 #include "src/handles-inl.h"
 #include "src/heap/heap.h"
@@ skipping 82 matching lines @@
                         JSFunction::kSharedFunctionInfoOffset,
                         Handle<Name>(),
                         Type::Any(),
                         MachineType::AnyTagged(),
                         kPointerWriteBarrier};
   return access;
 }
 
 
 // static
-FieldAccess AccessBuilder::ForJSFunctionLiterals() {
-  FieldAccess access = {
-      kTaggedBase,      JSFunction::kLiteralsOffset, Handle<Name>(),
-      Type::Internal(), MachineType::AnyTagged(),    kPointerWriteBarrier};
-  return access;
-}
-
-// static
 FieldAccess AccessBuilder::ForJSFunctionCodeEntry() {
   FieldAccess access = {kTaggedBase,
                         JSFunction::kCodeEntryOffset,
                         Handle<Name>(),
                         Type::UntaggedPointer(),
                         MachineType::Pointer(),
                         kNoWriteBarrier};
   return access;
 }
 
@@ skipping 291 matching lines @@
 
 
 // static
 FieldAccess AccessBuilder::ForPropertyCellValue(Type* type) {
   FieldAccess access = {
       kTaggedBase, PropertyCell::kValueOffset, Handle<Name>(),
       type,        MachineType::AnyTagged(),   kFullWriteBarrier};
   return access;
 }
 
+// static
+FieldAccess AccessBuilder::ForJSFunctionLiterals() {

[Michael Starzinger, 2016/05/10 13:47:20]

nit: Please keep these in the same order as in the header (i.e. move the
function to where it was before).

[mvstanton, 2016/05/24 16:31:49]

Done.

+  FieldAccess access = {
+      kTaggedBase,      JSFunction::kLiteralsOffset, Handle<Name>(),
+      Type::Internal(), MachineType::AnyTagged(),    kPointerWriteBarrier};
+  return access;
+}
 
 // static
-FieldAccess AccessBuilder::ForSharedFunctionInfoTypeFeedbackVector() {
-  FieldAccess access = {kTaggedBase,
-                        SharedFunctionInfo::kFeedbackVectorOffset,
-                        Handle<Name>(),
-                        Type::Any(),
-                        MachineType::AnyTagged(),
+FieldAccess AccessBuilder::ForLiteralsTypeFeedbackVector() {
+  FieldAccess access = {kTaggedBase, LiteralsArray::kFeedbackVectorOffset,
+                        Handle<Name>(), Type::Any(), MachineType::AnyTagged(),
                         kPointerWriteBarrier};
   return access;
 }
 
-
 // static
 ElementAccess AccessBuilder::ForFixedArrayElement() {
   ElementAccess access = {kTaggedBase, FixedArray::kHeaderSize, Type::Tagged(),
                           MachineType::AnyTagged(), kFullWriteBarrier};
   return access;
 }
 
 
 // static
 ElementAccess AccessBuilder::ForFixedDoubleArrayElement() {
@@ skipping 54 matching lines @@
   }
   UNREACHABLE();
   ElementAccess access = {kUntaggedBase, 0, Type::None(), MachineType::None(),
                           kNoWriteBarrier};
   return access;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8