Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/quic_crypto_stream.cc

Issue 1906803004: Fix a few spurious string allocations in QuicCryptoServerStream and QuicCryptoStream. No functional… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_crypto_server_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_stream.cc
diff --git a/net/quic/quic_crypto_stream.cc b/net/quic/quic_crypto_stream.cc
index ee44b6cd222305c01d7ef22818cd69267a766a19..f904871673714d17d636047ecf6547c460531485 100644
--- a/net/quic/quic_crypto_stream.cc
+++ b/net/quic/quic_crypto_stream.cc
@@ -72,7 +72,7 @@ void QuicCryptoStream::SendHandshakeMessage(
session()->OnCryptoHandshakeMessageSent(message);
const QuicData& data = message.GetSerialized();
// TODO(wtc): check the return value.
- WriteOrBufferData(string(data.data(), data.length()), false, listener);
+ WriteOrBufferData(StringPiece(data.data(), data.length()), false, listener);
}
bool QuicCryptoStream::ExportKeyingMaterial(StringPiece label,
« no previous file with comments | « net/quic/quic_crypto_server_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698