net/quic/quic_crypto_server_stream.cc - Issue 1906803004: Fix a few spurious string allocations in QuicCryptoServerStream and QuicCryptoStream. No functional…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_crypto_server_stream.cc

Issue 1906803004: Fix a few spurious string allocations in QuicCryptoServerStream and QuicCryptoStream. No functional… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_crypto_server_stream.cc

diff --git a/net/quic/quic_crypto_server_stream.cc b/net/quic/quic_crypto_server_stream.cc

index 26479489340734cf4857f99b82912bf814b250c9..7dbee38535fd2b28bd80a8e2026e008029bcafe4 100644

--- a/net/quic/quic_crypto_server_stream.cc

+++ b/net/quic/quic_crypto_server_stream.cc

@@ -238,7 +238,7 @@ void QuicCryptoServerStream::SendServerConfigUpdate(

DVLOG(1) << "Server: Sending server config update: "

<< server_config_update_message.DebugString();

const QuicData& data = server_config_update_message.GetSerialized();

- WriteOrBufferData(string(data.data(), data.length()), false, nullptr);

+ WriteOrBufferData(StringPiece(data.data(), data.length()), false, nullptr);

++num_server_config_update_messages_sent_;

}

« no previous file with comments | « no previous file | net/quic/quic_crypto_stream.cc » ('j') | no next file with comments »