Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1906803003: Allow dots in dimension key name. (Closed)

Created:
4 years, 8 months ago by M-A Ruel
Modified:
4 years, 8 months ago
Reviewers:
bpastene, nodir
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, borenet2, kjellander_chromium, nodir, rmistry1
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Allow dots in dimension key name. Too many project and tests depends on that. R=bpastene@chromium.org BUG=chromium:525873 BUG=chromium:604954 Committed: https://github.com/luci/luci-py/commit/808e212268907c3d1557aa2b7faadd0aebec33b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M appengine/swarming/server/task_request.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/server/task_request_test.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
M-A Ruel
4 years, 8 months ago (2016-04-21 14:19:43 UTC) #1
bpastene
lgtm That's too bad :( What's going to happen to dimension filtering in the actual ...
4 years, 8 months ago (2016-04-21 16:31:33 UTC) #2
nodir
lgtm
4 years, 8 months ago (2016-04-21 17:13:29 UTC) #4
M-A Ruel
On 2016/04/21 16:31:33, bpastene wrote: > lgtm > > That's too bad :( > What's ...
4 years, 8 months ago (2016-04-21 17:46:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906803003/1
4 years, 8 months ago (2016-04-21 17:46:09 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 17:49:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/808e212268907c3d1557aa2b7faadd0aebec33b7

Powered by Google App Engine
This is Rietveld 408576698