appengine/swarming/server/task_request_test.py - Issue 1906803003: Allow dots in dimension key name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/server/task_request_test.py

Issue 1906803003: Allow dots in dimension key name. (Closed) Base URL: git@github.com:luci/luci-py.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/swarming/server/task_request_test.py

diff --git a/appengine/swarming/server/task_request_test.py b/appengine/swarming/server/task_request_test.py

index f4dc2b3201d0ac67c04b4e9bffbf5597b9bd8bd3..12b24795f658916c3c61cb0c97c89bd081efdc63 100755

--- a/appengine/swarming/server/task_request_test.py

+++ b/appengine/swarming/server/task_request_test.py

@@ -374,7 +374,8 @@ class TaskRequestApiTest(TestCase):

_gen_request(

properties=dict(dimensions={u'id': u'b', u'a:': u'b'})), True)

task_request.make_request(

- _gen_request(properties=dict(dimensions={u'id': u'b'})), True)

+ _gen_request(

+ properties=dict(dimensions={u'id': u'b', u'a.': u'b'})), True)

with self.assertRaises(TypeError):

task_request.make_request(

« no previous file with comments | « appengine/swarming/server/task_request.py ('k') | no next file » | no next file with comments »