Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1906653004: [debugger] make step positions for for-of compatible with interpreter. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] make step positions for for-of compatible with interpreter. R=mstarzinger@chromium.org, rossberg@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/098ff93558767183098204d13ae1d4243f5fdb15 Cr-Commit-Position: refs/heads/master@{#35750}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : correctly rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 2 chunks +3 lines, -7 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 8 chunks +13 lines, -15 lines 0 comments Download
M test/mjsunit/es6/debug-stepnext-for.js View 5 chunks +17 lines, -6 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 29 (13 generated)
Yang
4 years, 8 months ago (2016-04-21 10:49:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906653004/1
4 years, 8 months ago (2016-04-21 13:42:11 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/537) v8_linux64_avx2_rel_ng on ...
4 years, 8 months ago (2016-04-21 13:43:41 UTC) #5
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-21 18:55:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906653004/20001
4 years, 8 months ago (2016-04-22 07:41:36 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/655) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 8 months ago (2016-04-22 08:01:09 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906653004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906653004/40001
4 years, 8 months ago (2016-04-22 09:56:39 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 10:44:57 UTC) #14
Yang
On 2016/04/22 10:44:57, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-22 12:22:15 UTC) #15
Yang
Adam, could you please take a look at src/parsing? Thanks!
4 years, 8 months ago (2016-04-22 18:40:42 UTC) #17
adamk
lgtm for src/parsing
4 years, 8 months ago (2016-04-22 18:43:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906653004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906653004/40001
4 years, 8 months ago (2016-04-22 18:47:19 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14063)
4 years, 8 months ago (2016-04-22 18:49:51 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906653004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906653004/60001
4 years, 8 months ago (2016-04-25 06:27:41 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-25 06:51:51 UTC) #27
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 06:53:48 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/098ff93558767183098204d13ae1d4243f5fdb15
Cr-Commit-Position: refs/heads/master@{#35750}

Powered by Google App Engine
This is Rietveld 408576698