Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1906653004: [debugger] make step positions for for-of compatible with interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1664 matching lines...) Expand 10 before | Expand all | Expand 10 after
1675 } else { 1675 } else {
1676 context()->Plug(v0); 1676 context()->Plug(v0);
1677 } 1677 }
1678 } 1678 }
1679 1679
1680 1680
1681 void FullCodeGenerator::VisitAssignment(Assignment* expr) { 1681 void FullCodeGenerator::VisitAssignment(Assignment* expr) {
1682 DCHECK(expr->target()->IsValidReferenceExpressionOrThis()); 1682 DCHECK(expr->target()->IsValidReferenceExpressionOrThis());
1683 1683
1684 Comment cmnt(masm_, "[ Assignment"); 1684 Comment cmnt(masm_, "[ Assignment");
1685 SetExpressionPosition(expr, INSERT_BREAK);
1686 1685
1687 Property* property = expr->target()->AsProperty(); 1686 Property* property = expr->target()->AsProperty();
1688 LhsKind assign_type = Property::GetAssignType(property); 1687 LhsKind assign_type = Property::GetAssignType(property);
1689 1688
1690 // Evaluate LHS expression. 1689 // Evaluate LHS expression.
1691 switch (assign_type) { 1690 switch (assign_type) {
1692 case VARIABLE: 1691 case VARIABLE:
1693 // Nothing to do here. 1692 // Nothing to do here.
1694 break; 1693 break;
1695 case NAMED_PROPERTY: 1694 case NAMED_PROPERTY:
(...skipping 2289 matching lines...) Expand 10 before | Expand all | Expand 10 after
3985 reinterpret_cast<uint32_t>( 3984 reinterpret_cast<uint32_t>(
3986 isolate->builtins()->OnStackReplacement()->entry())); 3985 isolate->builtins()->OnStackReplacement()->entry()));
3987 return ON_STACK_REPLACEMENT; 3986 return ON_STACK_REPLACEMENT;
3988 } 3987 }
3989 3988
3990 3989
3991 } // namespace internal 3990 } // namespace internal
3992 } // namespace v8 3991 } // namespace v8
3993 3992
3994 #endif // V8_TARGET_ARCH_MIPS 3993 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698