Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1906483002: Remove Disposed as a DocumentLifecycle state. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken, esprehn
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Disposed as a DocumentLifecycle state. With Oilpan, Documents no longer have an observable 'disposed' state. R= BUG=585328 Committed: https://crrev.com/6bf9cf81374dfdbd6fc0bd6420c260d9a8793ce8 Cr-Commit-Position: refs/heads/master@{#388498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-20 12:06:43 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-20 12:36:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906483002/1
4 years, 8 months ago (2016-04-20 15:02:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 15:05:51 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:23:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bf9cf81374dfdbd6fc0bd6420c260d9a8793ce8
Cr-Commit-Position: refs/heads/master@{#388498}

Powered by Google App Engine
This is Rietveld 408576698