Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp

Issue 1906483002: Remove Disposed as a DocumentLifecycle state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentLifecycle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
diff --git a/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp b/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
index f68a509f2c66ca3a4cdde296a33d6417eaf63f96..382a94d3ac83141f084f5618ab3f5a663b45c94b 100644
--- a/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
+++ b/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
@@ -100,8 +100,6 @@ bool DocumentLifecycle::canAdvanceTo(LifecycleState nextState) const
case Inactive:
if (nextState == StyleClean)
return true;
- if (nextState == Disposed)
- return true;
break;
case VisualUpdatePending:
if (nextState == InPreLayout)
@@ -239,11 +237,7 @@ bool DocumentLifecycle::canAdvanceTo(LifecycleState nextState) const
case Stopping:
return nextState == Stopped;
case Stopped:
- return nextState == Disposed;
- case Disposed:
- // FIXME: We can dispose a document multiple times. This seems wrong.
- // See https://code.google.com/p/chromium/issues/detail?id=301668.
- return nextState == Disposed;
+ return false;
}
return false;
}
@@ -320,7 +314,6 @@ const char* DocumentLifecycle::stateAsDebugString(const LifecycleState state)
DEBUG_STRING_CASE(PaintClean);
DEBUG_STRING_CASE(Stopping);
DEBUG_STRING_CASE(Stopped);
- DEBUG_STRING_CASE(Disposed);
}
ASSERT_NOT_REACHED();
« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentLifecycle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698