third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp - Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMarqueeElement.js ('k') | third_party/WebKit/Source/core/style/DataEquivalency.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

index ae0d0accc2aa5c2914d32ec91cf78a6f11908e90..6a3ecbd6c720d41edb6b26d1ea07311d490207f1 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

@@ -333,6 +333,7 @@ void InspectorAnimationAgent::setTiming(ErrorString* errorString, const String&

return;

animation = animationClone(animation);

+ NonThrowableExceptionState exceptionState;

String type = m_idToAnimationType.get(animationId);

if (type == AnimationType::CSSTransition) {

@@ -352,12 +353,12 @@ void InspectorAnimationAgent::setTiming(ErrorString* errorString, const String&

AnimationEffectTiming* timing = animation->effect()->timing();

UnrestrictedDoubleOrString unrestrictedDuration;

unrestrictedDuration.setUnrestrictedDouble(duration + delay);

- timing->setDuration(unrestrictedDuration);

+ timing->setDuration(unrestrictedDuration, exceptionState);

} else {

AnimationEffectTiming* timing = animation->effect()->timing();

UnrestrictedDoubleOrString unrestrictedDuration;

unrestrictedDuration.setUnrestrictedDouble(duration);

- timing->setDuration(unrestrictedDuration);

+ timing->setDuration(unrestrictedDuration, exceptionState);

timing->setDelay(delay);

}