third_party/WebKit/Source/core/html/HTMLMarqueeElement.js - Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMarqueeElement.js

Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/TimingInputTest.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMarqueeElement.js

diff --git a/third_party/WebKit/Source/core/html/HTMLMarqueeElement.js b/third_party/WebKit/Source/core/html/HTMLMarqueeElement.js

index 5ae3e64bea5dab39151a4346b0fdc47c246dad9b..e387c671c6e37f998c38b23147b6a86f3ebf6182 100644

--- a/third_party/WebKit/Source/core/html/HTMLMarqueeElement.js

+++ b/third_party/WebKit/Source/core/html/HTMLMarqueeElement.js

@@ -355,11 +355,14 @@ privateScriptController.installClass('HTMLMarqueeElement', function(HTMLMarqueeE

var scrollDelay = this.scrollDelay;

if (scrollDelay < kMinimumScrollDelayMS && !this.trueSpeed)

scrollDelay = kDefaultScrollDelayMS;

+ var duration = 0;

+ if (this.scrollAmount && !isNaN(parameters.distance))

+ duration = parameters.distance * scrollDelay / this.scrollAmount;

var player = this.mover_.animate([

{ transform: parameters.transformBegin },

{ transform: parameters.transformEnd },

], {

- duration: this.scrollAmount == 0 ? 0 : parameters.distance * scrollDelay / this.scrollAmount,

+ duration,

fill: 'forwards',

});

player.marquee_ = this;