third_party/protobuf/BUILD.gn - Issue 1906193002: Fixing gn manifests for many executables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/BUILD.gn

Issue 1906193002: Fixing gn manifests for many executables (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/BUILD.gn

diff --git a/third_party/protobuf/BUILD.gn b/third_party/protobuf/BUILD.gn

index 66bd4acc0dfb33b6b9a27c5f27bf9eb4e95c633b..17eae164d5da8af4a1a24569a591aeafdbbe4dfb 100644

--- a/third_party/protobuf/BUILD.gn

+++ b/third_party/protobuf/BUILD.gn

@@ -533,6 +533,9 @@ if (current_toolchain == host_toolchain) {

deps = [

":protobuf_full",

"//build/config/sanitizers:deps",

+ # Default manifest on Windows (a no-op elsewhere).

+ "//build/win:default_exe_manifest",

]

deps += [ "//build/config/sanitizers:deps" ]

}

« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »