WebUSB Android chooser should be closed when "Get help" button is pressed

WebUSB Android chooser should be closed when "Get help" button is pressed

When "Get help" button is pressed and a new tab is opened, the WebUSB
Android chooser dialog box is not closed and it overlaps the top part of
the new tab. This patch added code to close the dialog box.

BUG=605716, 591735
Committed: https://crrev.com/17e34ed9008b1b1bedebbbbac4db62e8b983d690
Cr-Commit-Position: refs/heads/master@{#388939}

[juncai, 2016-04-21 20:54:15]

juncai@chromium.org changed reviewers:
+ yfriedman@chromium.org

[juncai, 2016-04-21 20:54:15]

Please take a look.

[Yaron, 2016-04-21 21:45:37]

https://codereview.chromium.org/1906183002/diff/1/chrome/browser/ui/android/u...
File chrome/browser/ui/android/usb_chooser_dialog_android.cc (right):

https://codereview.chromium.org/1906183002/diff/1/chrome/browser/ui/android/u...
chrome/browser/ui/android/usb_chooser_dialog_android.cc:169:
callback_.Run(nullptr);
Just call |Cancel|?

[juncai, 2016-04-21 21:55:07]

https://codereview.chromium.org/1906183002/diff/1/chrome/browser/ui/android/u...
File chrome/browser/ui/android/usb_chooser_dialog_android.cc (right):

https://codereview.chromium.org/1906183002/diff/1/chrome/browser/ui/android/u...
chrome/browser/ui/android/usb_chooser_dialog_android.cc:169:
callback_.Run(nullptr);
On 2016/04/21 21:45:37, Yaron wrote:
> Just call |Cancel|?

Done.

[Yaron, 2016-04-21 22:19:25]

lgtm

[juncai, 2016-04-21 22:27:57]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:28:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906183002/20001

[commit-bot: I haz the power, 2016-04-21 23:04:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:41:08]

Description was changed from

==========
WebUSB Android chooser should be closed when "Get help" button is pressed

When "Get help" button is pressed and a new tab is opened, the WebUSB
Android chooser dialog box is not closed and it overlaps the top part of
the new tab. This patch added code to close the dialog box.

BUG=605716, 591735
==========

to

==========
WebUSB Android chooser should be closed when "Get help" button is pressed

When "Get help" button is pressed and a new tab is opened, the WebUSB
Android chooser dialog box is not closed and it overlaps the top part of
the new tab. This patch added code to close the dialog box.

BUG=605716, 591735

Committed: https://crrev.com/17e34ed9008b1b1bedebbbbac4db62e8b983d690
Cr-Commit-Position: refs/heads/master@{#388939}
==========

[commit-bot: I haz the power, 2016-04-22 19:41:09]

Patchset 2 (id:??) landed as
https://crrev.com/17e34ed9008b1b1bedebbbbac4db62e8b983d690
Cr-Commit-Position: refs/heads/master@{#388939}