chrome/browser/ui/android/usb_chooser_dialog_android.cc - Issue 1906183002: WebUSB Android chooser should be closed when "Get help" button is pressed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/usb_chooser_dialog_android.cc

Issue 1906183002: WebUSB Android chooser should be closed when "Get help" button is pressed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address yfriedman@'s comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/android/usb_chooser_dialog_android.cc

diff --git a/chrome/browser/ui/android/usb_chooser_dialog_android.cc b/chrome/browser/ui/android/usb_chooser_dialog_android.cc

index f1454a314d44453b660396d9320d11a97b9adbab..c2452973302ca924e416563a0fe728181612b36b 100644

--- a/chrome/browser/ui/android/usb_chooser_dialog_android.cc

+++ b/chrome/browser/ui/android/usb_chooser_dialog_android.cc

@@ -166,6 +166,7 @@ void UsbChooserDialogAndroid::LoadUsbHelpPage(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj) {

OpenUrl(chrome::kChooserUsbOverviewURL);

+ Cancel();

}

// Get a list of devices that can be shown in the chooser bubble UI for

« no previous file with comments | « no previous file | no next file » | no next file with comments »