Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906173003: Record domains where Reader Mode is opened for too short (Closed)

Created:
4 years, 8 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record domains where Reader Mode is opened for too short Opening the Reader Mode for only a short period of time is a signal that the distilled content is not useful. We want to know more about this case by recording the domains. BUG=605795

Patch Set 1 #

Patch Set 2 : move to constant #

Total comments: 1

Patch Set 3 : move const to instance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wychen
PTAL
4 years, 8 months ago (2016-04-22 00:50:11 UTC) #3
mdjones
lgtm; consider making 2000 ms a constant.
4 years, 8 months ago (2016-04-22 01:04:59 UTC) #4
wychen
On 2016/04/22 01:04:59, mdjones wrote: > lgtm; consider making 2000 ms a constant. Done.
4 years, 8 months ago (2016-04-22 04:02:59 UTC) #5
mdjones
nit https://codereview.chromium.org/1906173003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java (right): https://codereview.chromium.org/1906173003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java#newcode292 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java:292: long shortTimeThreshold = 2000; I was thinking more ...
4 years, 8 months ago (2016-04-22 15:22:41 UTC) #6
wychen
3 years, 7 months ago (2017-05-16 22:35:26 UTC) #7 
This doesn't work. We can use UKM instead.

Powered by Google App Engine
This is Rietveld 408576698