Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

Issue 1906173003: Record domains where Reader Mode is opened for too short (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move const to instance Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
index cedcb0870288cc0a76c922edd374b2bcfb7956f1..6cac3105dcf84486bc8a6b379f9032cbdc55a471 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
@@ -31,6 +31,8 @@ import org.chromium.ui.resources.ResourceManager;
* The panel containing reader mode.
*/
public class ReaderModePanel extends OverlayPanel {
+ /** If the user only opens the panel for less than 2 seconds, it is considered unhelpful. */
+ private static final int SHORT_TIME_FOR_RECORD = 2000;
/** The compositor layer used for drawing the panel. */
private ReaderModeSceneLayer mSceneLayer;
@@ -287,6 +289,12 @@ public class ReaderModePanel extends OverlayPanel {
long totalTime = System.currentTimeMillis() - mStartTime;
if (mStartTime <= 0 || totalTime < 0) return;
mManagerDelegate.recordTimeSpentInReader(totalTime);
+
+ if (totalTime < SHORT_TIME_FOR_RECORD) {
+ String url = mManagerDelegate.getBasePageWebContents().getUrl();
+ RapporServiceBridge.sampleDomainAndRegistryFromURL(
+ "DomDistiller.OpenPanelShortTime", url);
+ }
}
@Override
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698