cc: Stop cache transform invertibility at Layer and LayerImpl

cc: Stop cache transform invertibility at Layer and LayerImpl

Transform invertibility is cached just to be used at PreCalcMetaInfo.
Even if this caching is needed, could do it on transform tree in the
future.

R=ajuma
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ab923149fe703c14e121ba788bd1a2737d90ede9
Cr-Commit-Position: refs/heads/master@{#390992}

[weiliangc, 2016-04-21 15:40:07]

Description was changed from

==========
cc: Stop cache transform invertibility at Layer and LayerImpl

Transform invertibility is cached just to be used at PreCalcMetaInfo.
Even if this caching is needed, could do it on transform tree in the
future.

R=ajuma
BUG=
==========

to

==========
cc: Stop cache transform invertibility at Layer and LayerImpl

Transform invertibility is cached just to be used at PreCalcMetaInfo.
Even if this caching is needed, could do it on transform tree in the
future.

R=ajuma
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[weiliangc, 2016-04-21 15:43:39]

More drive-by clean up :)

[ajuma, 2016-04-21 17:20:11]

lgtm

https://codereview.chromium.org/1906003002/diff/20001/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/1906003002/diff/20001/cc/layers/layer.cc#newc...
cc/layers/layer.cc:606: return a.Preserves2dAxisAlignment();
It seems like we'd want to return false here, since b is uninvertible. The
behavior isn't changing in this CL though, it's just making the logic easier to
see :)  Perhaps leave a TODO about this?

[weiliangc, 2016-05-02 15:01:27]

The CQ bit was checked by weiliangc@chromium.org

[weiliangc, 2016-05-02 15:01:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1906003002/#ps60001
(title: "address review comments")

[commit-bot: I haz the power, 2016-05-02 15:01:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906003002/60001

[weiliangc, 2016-05-02 15:02:00]

On 2016/04/21 at 17:20:11, ajuma wrote:
> lgtm
> 
> https://codereview.chromium.org/1906003002/diff/20001/cc/layers/layer.cc
> File cc/layers/layer.cc (right):
> 
>
https://codereview.chromium.org/1906003002/diff/20001/cc/layers/layer.cc#newc...
> cc/layers/layer.cc:606: return a.Preserves2dAxisAlignment();
> It seems like we'd want to return false here, since b is uninvertible. The
behavior isn't changing in this CL though, it's just making the logic easier to
see :)  Perhaps leave a TODO about this?

Added the TODO.

[weiliangc, 2016-05-02 15:09:40]

The CQ bit was unchecked by weiliangc@chromium.org

[weiliangc, 2016-05-02 17:31:00]

The CQ bit was checked by weiliangc@chromium.org

[weiliangc, 2016-05-02 17:31:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1906003002/#ps80001
(title: "re-remove skipping due to invertibility in precalc, this was lost in
rebase")

[commit-bot: I haz the power, 2016-05-02 17:31:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906003002/80001

[commit-bot: I haz the power, 2016-05-02 18:10:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-02 18:11:53]

Description was changed from

==========
cc: Stop cache transform invertibility at Layer and LayerImpl

Transform invertibility is cached just to be used at PreCalcMetaInfo.
Even if this caching is needed, could do it on transform tree in the
future.

R=ajuma
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Stop cache transform invertibility at Layer and LayerImpl

Transform invertibility is cached just to be used at PreCalcMetaInfo.
Even if this caching is needed, could do it on transform tree in the
future.

R=ajuma
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ab923149fe703c14e121ba788bd1a2737d90ede9
Cr-Commit-Position: refs/heads/master@{#390992}
==========

[commit-bot: I haz the power, 2016-05-02 18:11:54]

Patchset 5 (id:??) landed as
https://crrev.com/ab923149fe703c14e121ba788bd1a2737d90ede9
Cr-Commit-Position: refs/heads/master@{#390992}