Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2489)

Unified Diff: cc/trees/property_tree_builder.cc

Issue 1906003002: cc: Stop cache transform invertibility at Layer and LayerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-remove skipping due to invertibility in precalc, this was lost in rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_common.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree_builder.cc
diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc
index 1c4c7724eedc79ec8764c9303fc85a8a11ccc60a..4027cffcb9ec798a38fe8ae5831fc8ed77028e4a 100644
--- a/cc/trees/property_tree_builder.cc
+++ b/cc/trees/property_tree_builder.cc
@@ -106,16 +106,6 @@ static inline bool IsRootLayer(const Layer* layer) {
return !layer->parent();
}
-static bool HasInvertibleOrAnimatedTransform(Layer* layer) {
- return layer->transform_is_invertible() ||
- layer->HasPotentiallyRunningTransformAnimation();
-}
-
-static bool HasInvertibleOrAnimatedTransformForTesting(LayerImpl* layer) {
- return layer->transform().IsInvertible() ||
- layer->HasPotentiallyRunningTransformAnimation();
-}
-
static bool IsMetaInformationRecomputationNeeded(Layer* layer) {
return layer->layer_tree_host()->needs_meta_info_recomputation();
}
@@ -133,12 +123,6 @@ static void PreCalculateMetaInformationInternal(
if (layer->clip_parent())
recursive_data->num_unclipped_descendants++;
- if (!HasInvertibleOrAnimatedTransform(layer)) {
- // Layers with singular transforms should not be drawn, the whole subtree
- // can be skipped.
- return;
- }
-
for (size_t i = 0; i < layer->children().size(); ++i) {
Layer* child_layer = layer->child_at(i);
@@ -172,12 +156,6 @@ static void PreCalculateMetaInformationInternalForTesting(
if (layer->test_properties()->clip_parent)
recursive_data->num_unclipped_descendants++;
- if (!HasInvertibleOrAnimatedTransformForTesting(layer)) {
- // Layers with singular transforms should not be drawn, the whole subtree
- // can be skipped.
- return;
- }
-
for (size_t i = 0; i < layer->children().size(); ++i) {
LayerImpl* child_layer = layer->child_at(i);
« no previous file with comments | « cc/trees/layer_tree_host_common.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698