Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1905923002: Don't lose the pagination strut when a line is re-created. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't lose the pagination strut when a line is re-created. If there's not enough room for a line in a column, so that it gets pushed to the next one, and there's a float at the top of the next column, the available line width changes, and we need to re-create the line at the new position. Do not lose the pagination strut in the process, or the column balancer might over-stretch the columns, since it might fail to find the lowest possible space shortage for the next layout pass. So store the strut so that we can re-apply it when the new line has been created. Since we now store the strut of such lines while they're being re-created, this can be used as a flag to skip positioning of out-of-flow objects and floats. In other words, we can retire the logicalWidthIsAvailable flag (which was a really confusing name anyway). Committed: https://crrev.com/afd633d1bb2b6ca6149eb70b8860189753105d53 Cr-Commit-Position: refs/heads/master@{#388884}

Patch Set 1 #

Patch Set 2 : Wrong relative path to resources/ #

Total comments: 2

Patch Set 3 : Make a reftest instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -18 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float-expected.html View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 3 chunks +39 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-21 16:31:28 UTC) #2
eae
LGTM w/suggestions https://codereview.chromium.org/1905923002/diff/20001/third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html File third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html (right): https://codereview.chromium.org/1905923002/diff/20001/third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html#newcode8 third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html:8: <div data-expected-height="40" id="multicol"> This might be better ...
4 years, 8 months ago (2016-04-21 16:44:21 UTC) #3
mstensho (USE GERRIT)
https://codereview.chromium.org/1905923002/diff/20001/third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html File third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html (right): https://codereview.chromium.org/1905923002/diff/20001/third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html#newcode8 third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html:8: <div data-expected-height="40" id="multicol"> On 2016/04/21 16:44:21, eae wrote: > ...
4 years, 8 months ago (2016-04-21 18:56:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905923002/40001
4 years, 8 months ago (2016-04-21 18:57:33 UTC) #7
wkorman
lgtm No need to stop CQ but if it doesn't go straight in and there's ...
4 years, 8 months ago (2016-04-21 19:21:14 UTC) #8
mstensho (USE GERRIT)
On 2016/04/21 19:21:14, wkorman wrote: > lgtm > > No need to stop CQ but ...
4 years, 8 months ago (2016-04-21 19:24:26 UTC) #9
wkorman
On 2016/04/21 at 19:24:26, mstensho wrote: > On 2016/04/21 19:21:14, wkorman wrote: > > lgtm ...
4 years, 8 months ago (2016-04-21 19:28:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-21 20:37:26 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:38:55 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/afd633d1bb2b6ca6149eb70b8860189753105d53
Cr-Commit-Position: refs/heads/master@{#388884}

Powered by Google App Engine
This is Rietveld 408576698